lianguan/gitea
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused comment actions (#9222)

Browse Source 
* Remove unused comment actions

* improve code
This commit is contained in:
Lunny Xiao
2019-12-02 22:43:39 +08:00
committed by Lauris BH
parent 2fc3eb1d15
commit 6e81eafdd6
6 changed files with 10 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
models/issue_comment.go
View File

@ -678,7 +678,7 @@ func createDeadlineComment(e *xorm.Session, doer *User, issue *Issue, newDeadlin
if err != nil {
return nil, err
}
return comment, sendCreateCommentAction(e, opts, comment)
return comment, nil
}
// Creates issue dependency comment
@ -699,13 +699,9 @@ func createIssueDependencyComment(e *xorm.Session, doer *User, issue *Issue, dep
Issue: issue,
DependentIssueID: dependentIssue.ID,
}
comment, err := createCommentWithNoAction(e, opts)
if err != nil {
if _, err = createCommentWithNoAction(e, opts); err != nil {
return
}
if err = sendCreateCommentAction(e, opts, comment); err != nil {
return err
}
opts = &CreateCommentOptions{
Type: cType,
@ -714,14 +710,7 @@ func createIssueDependencyComment(e *xorm.Session, doer *User, issue *Issue, dep
Issue: dependentIssue,
DependentIssueID: issue.ID,
}
comment, err = createCommentWithNoAction(e, opts)
if err != nil {
return
}
if err = sendCreateCommentAction(e, opts, comment); err != nil {
return err
}
_, err = createCommentWithNoAction(e, opts)
return
}