lianguan/gitea
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix cache bug (#30510)

Browse Source 
Cache cannot be disabled from v1.22. So it still maybe `nil` in v1.21,
we have to check whether cache is `nil`.
This commit is contained in:
Lunny Xiao 2024-04-16 10:59:15 +08:00 committed by GitHub
parent 727b1914b4
commit acdcfcc6eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
services/repository/commitstatus/commitstatus.go
View File

@ -32,6 +32,9 @@ type commitStatusCacheValue struct {
func getCommitStatusCache(repoID int64, branchName string) *commitStatusCacheValue { func getCommitStatusCache(repoID int64, branchName string) *commitStatusCacheValue {
c := cache.GetCache() c := cache.GetCache()
if c == nil {
return nil
}
statusStr, ok := c.Get(getCacheKey(repoID, branchName)).(string) statusStr, ok := c.Get(getCacheKey(repoID, branchName)).(string)
if ok && statusStr != "" { if ok && statusStr != "" {
var cv commitStatusCacheValue var cv commitStatusCacheValue
@ -48,6 +51,9 @@ func getCommitStatusCache(repoID int64, branchName string) *commitStatusCacheVal
func updateCommitStatusCache(repoID int64, branchName string, state api.CommitStatusState, targetURL string) error { func updateCommitStatusCache(repoID int64, branchName string, state api.CommitStatusState, targetURL string) error {
c := cache.GetCache() c := cache.GetCache()
if c == nil {
return nil
}
bs, err := json.Marshal(commitStatusCacheValue{ bs, err := json.Marshal(commitStatusCacheValue{
State: state.String(), State: state.String(),
TargetURL: targetURL, TargetURL: targetURL,