Backport #25476 by @GeorgDangl In the process of doing a bit of automation via the API, we've discovered a _small_ issue in the Swagger definition. We tried to create a push mirror for a repository, but our generated client raised an exception due to an unexpected status code. When looking at this function:3c7f5ed7b5/routers/api/v1/repo/mirror.go (L236-L240)
We see it defines `201 - Created` as response:3c7f5ed7b5/routers/api/v1/repo/mirror.go (L260-L262)
But it actually returns `200 - OK`:3c7f5ed7b5/routers/api/v1/repo/mirror.go (L373)
So I've just updated the Swagger definitions to match the code😀 Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>
This commit is contained in:
parent
77db40e084
commit
b2b5c80cb2
@ -258,7 +258,7 @@ func AddPushMirror(ctx *context.APIContext) {
|
||||
// schema:
|
||||
// "$ref": "#/definitions/CreatePushMirrorOption"
|
||||
// responses:
|
||||
// "201":
|
||||
// "200":
|
||||
// "$ref": "#/responses/PushMirror"
|
||||
// "403":
|
||||
// "$ref": "#/responses/forbidden"
|
||||
|
2
templates/swagger/v1_json.tmpl
generated
2
templates/swagger/v1_json.tmpl
generated
@ -10729,7 +10729,7 @@
|
||||
}
|
||||
],
|
||||
"responses": {
|
||||
"201": {
|
||||
"200": {
|
||||
"$ref": "#/responses/PushMirror"
|
||||
},
|
||||
"400": {
|
||||
|
Loading…
x
Reference in New Issue
Block a user