6fc129fe62
Fix repository create/delete event webhooks ( #13008 )
...
This small PR changes the webhook trigger behaviour to be more in line with what's expected. (When 'repository' events are enabled, of course)
In other words:
For system-wide or default webhooks, repository events will now trigger said webhook. Previously it had to be under an organization for create events to be visible - a tad unexpected!
Deleting a repository will now fire its own defined webhooks, not just organisational and system ones.
In order to enable the latter the webhook has to now be triggered before the actual repo undergoes deletion. I'm willing to tweak this to try and 'grab' the webhook model beforehand and trigger the webhook notifier directly afterwards, but this may make the code more complex for little benefit.
Closes #11766 , #9180 .
2020-10-02 10:37:46 +01:00
3f1c0841cb
Granular webhook events ( #9626 )
...
* Initial work
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add PR reviews and API coverage
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Split up events
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add migration and locale
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Format
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Revert IsPull
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix comments
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix PR reviews
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix issue_comment
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Make fmt
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Migrations
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Backwards compatible API
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix feishu
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move session commit
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-03-06 07:10:48 +02:00
7e8cdba181
[Refactor] move APIFormat() of Issue and Label to convert package ( #10423 )
...
* Label: delete .APIFormat() and use convert.ToLabel()
* move issue APIFormat too
* add missing one
* move TEST too
* handle error -> return empty APIIssue
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-28 23:49:50 -03:00
542bd59239
Fix webhook bug ( #10427 )
...
Co-authored-by: techknowlogick <matti@mdranta.net >
2020-02-23 13:49:40 -05:00
06cd3e03a2
[refactor] notify remove unused praram ( #9804 )
2020-01-16 17:24:20 +01:00
99d869fa63
Move push commits from models to modules/repository ( #9370 )
...
* Move push commits from models to modules/repository
* fix test
* fix test
* fix test
* fix test
* fix test
Co-authored-by: zeripath <art27@cantab.net >
2020-01-10 17:34:21 +08:00
384c2b342e
Move pull request api convert to convert package ( #9664 )
...
* Move pull request api convert to convert package
* Rename ToPullRequest to ToAPIPullRequest
2020-01-10 15:53:53 +08:00
61db834904
Change target branch for pull request ( #6488 )
...
* Adds functionality to change target branch of created pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use const instead of var in JavaScript additions
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Check if branches are equal and if PR already exists before changing target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Make sure to check all commits
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Print error messages for user as error flash message
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Disallow changing target branch of closed or merged pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Resolve conflicts after merge of upstream/master
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Change order of branch select fields
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes duplicate check
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use ctx.Tr for translations
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Recompile JS
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use correct translation namespace
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove redundant if condition
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves most change branch logic into pull service
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Completes comment
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Add Ref to ChangesPayload for logging changed target branches
instead of creating a new struct
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Revert changes to go.mod
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Directly use createComment method
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return 404 if pull request is not found. Move written check up
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove variable declaration
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return client errors on change pull request target errors
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return error in commit.HasPreviousCommit
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds blank line
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Test patch before persisting new target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update patch before testing (not working)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes patch calls when changeing pull request target
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes unneeded check for base name
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves ChangeTargetBranch completely to pull service. Update patch status.
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Set webhook mode after errors were validated
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update PR in one transaction
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Move logic for check if head is equal with branch to pull model
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds missing comment and simplify return
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adjust CreateComment method call
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
2019-12-16 14:20:25 +08:00
67b316a954
Refactor comment ( #9330 )
...
* Refactor comment
* fix test
* improve code
2019-12-15 16:57:34 -05:00
8ab35eefc4
Move mirror sync actions to notification ( #9022 )
...
* Move mirror sync actions to notification
* fix lint
2019-11-24 00:16:59 -05:00
d7ac9727bb
Move merge actions to notification ( #9024 )
...
* Move merge actions to notification
* Add missing mail notification
2019-11-21 12:08:42 -05:00
722a7c902d
Add Close() method to gogitRepository ( #8901 )
...
In investigating #7947 it has become clear that the storage component of go-git repositories needs closing.
This PR adds this Close function and adds the Close functions as necessary.
In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files.
Fixes #7947
2019-11-13 07:01:19 +00:00
253fdfb7fa
Fix Notify Create Ref Error on tag creation ( #8936 )
...
* Fix Notify Create Ref Error on tag creation
* Just use the provided full ref instead of BranchCommit
2019-11-13 00:49:40 +01:00
0109229928
Move release webhook to notification ( #8817 )
...
* Move release webhook to notification
* Extract release webhook method
* fix bug
* fix import
2019-11-06 16:25:50 +08:00
8a84d82d53
Move repofiles webhooks to notification ( #8807 )
2019-11-06 14:43:03 +08:00
aaeef295bb
Move pull webhook to notification ( #8805 )
...
* Move pull webhook to notification
* fix fmt
2019-11-05 19:04:08 +08:00
491887d441
Move actions to notification ( #8785 )
2019-11-03 20:59:09 +00:00
022d2d8beb
Move push commits events to notification ( #8783 )
...
* Move push commits events to notification
* Update modules/notification/base/null.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
2019-11-03 14:59:26 +08:00
8f26397928
Move issue milestone assign to issue service and move webhook to notification ( #8780 )
2019-11-02 11:33:20 +08:00
f518fe6662
Rename HookQueue to hookQueue ( #8778 )
...
* Rename HookQueue to hookQueue
* fix lint
2019-11-02 10:35:12 +08:00
4b8d9e58c5
Move labels webhooks to notification ( #8749 )
...
* Move webhooks to notification
* fix notification
2019-11-02 09:49:57 +08:00
0e7f7df3cf
Move webhook to a standalone package under modules ( #8747 )
...
* Move webhook to a standalone package under modules
* fix test
* fix comments
2019-11-01 22:51:22 +00:00
ac6accef09
Move webhook codes from service to webhook notification ( #8712 )
...
* Move webhook codes from service to webhook notification
* move deletecomment webhook to notifications
* fix notification
2019-10-30 12:02:46 +02:00
f694bb45d7
Move issue change content from models to service ( #8711 )
...
* Move issue change content from models to service
* fix lint
2019-10-30 10:36:25 +02:00
af8957bc4c
Move issue notifications ( #8713 )
2019-10-29 00:45:43 +08:00
c66c9dabc7
Move issue change status from models to service ( #8691 )
2019-10-28 13:26:46 +08:00
495d5e4329
Move more issue assignee code from models to issue service ( #8690 )
...
* Move more issue assignee code from models to issue service
* fix test
2019-10-28 10:11:50 +08:00
9e85358777
Move some repositories' operations to a standalone service package ( #8557 )
...
* Move some repositories' operations to a standalone service package
* improve code
* remove unused codes
* add rollback when fork failed
* add repo when return
2019-10-26 14:54:11 +08:00
20477a69ea
Move clearlabels from models to issue service ( #8326 )
...
* move clearlabels from models to issue service
* improve code
* Apply suggestions from code review
Co-Authored-By: zeripath <art27@cantab.net >
2019-10-15 13:03:05 +08:00
