mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334)
* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes
2019-03-18 10:00:23 -04:00
..
2019-03-09 16:15:45 -05:00
2019-02-02 21:56:15 +00:00
2019-03-08 11:42:50 -05:00
2019-03-09 16:15:45 -05:00
2018-10-27 22:45:24 +08:00
2019-02-19 09:39:39 -05:00
2018-05-09 19:29:04 +03:00
2019-03-08 11:42:50 -05:00
2018-10-25 18:55:16 +08:00
2019-01-13 14:06:22 -05:00
2019-02-07 12:00:52 +00:00
2018-10-26 12:37:57 +03:00
2018-10-20 18:19:21 -04:00
2019-03-03 17:57:24 -05:00
2019-03-08 11:42:50 -05:00