lunny/changelog
1
0
Fork 2
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Add generate from issues argument #44

Merged
jaqra merged 1 commits from generate_from_issues into master 2020-08-04 13:30:22 +00:00
Conversation 0 Commits 1 Files Changed 1 +4 -4
jaqra commented 2020-07-29 21:02:53 +00:00 (Migrated from gitea.com)
Copy Link

In small projects we push direct to branch (does not send pr), we should create changelog from closed issues

In small projects we push direct to branch (does not send pr), we should create changelog from closed issues
👍 2 ❤️ 1
jolheiser (Migrated from gitea.com) reviewed 2020-07-30 13:40:55 +00:00
zeripath (Migrated from gitea.com) approved these changes 2020-07-30 13:44:46 +00:00
zeripath (Migrated from gitea.com) left a comment
Copy Link

This looks fine to me - I would say that the number of arguments to:
service/service.go:15:func New(...) is getting a little unwieldy and perhaps
next time we should move to an Options based approach.

This looks fine to me - I would say that the number of arguments to: `service/service.go:15:func New(...)` is getting a little unwieldy and perhaps next time we should move to an Options based approach.
jaqra (Migrated from gitea.com) reviewed 2020-07-30 13:58:22 +00:00
jolheiser (Migrated from gitea.com) reviewed 2020-07-30 17:03:52 +00:00
jolheiser (Migrated from gitea.com) reviewed 2020-07-30 18:30:41 +00:00
jolheiser (Migrated from gitea.com) left a comment
Copy Link

One more nit, then I think it LGTM

One more nit, then I think it LGTM
jolheiser (Migrated from gitea.com) approved these changes 2020-08-04 13:29:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
zeripath
jolheiser
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
lgtm/done

   
lgtm/need 1

   
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm/done
lgtm/need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/changelog#44
No description provided.
Delete Branch "generate_from_issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?