Include PR Author Name in changelog #73

Open
opened 2023-03-17 02:20:57 +00:00 by techknowlogick · 3 comments
techknowlogick commented 2023-03-17 02:20:57 +00:00 (Migrated from gitea.com)

In addition to the PR #, we could also include the @ of the PR author (this may be difficult with Giteabot being the user who opens the PR though).

In addition to the PR #, we could also include the @ of the PR author (this may be difficult with Giteabot being the user who opens the PR though).
jolheiser commented 2023-03-17 02:23:53 +00:00 (Migrated from gitea.com)

It may need a token, but could we use the commit author? (an extra N API hits to get commit info)

Not sure, though, as we squash merge.

It may need a token, but could we use the commit author? (an extra N API hits to get commit info) Not sure, though, as we squash merge.
techknowlogick commented 2023-03-17 03:05:32 +00:00 (Migrated from gitea.com)

It may need a token, but could we use the commit author? (an extra N API hits to get commit info)

It's been a sec since I've been in the changelog codebase (ignoring the CI commits I did recently), but we could optionally use the token if the appropriate env var is set.

Not sure, though, as we squash merge.

May require some parsing of the commit message to get co-authors (if needed) as well.

> It may need a token, but could we use the commit author? (an extra N API hits to get commit info) It's been a sec since I've been in the changelog codebase (ignoring the CI commits I did recently), but we could optionally use the token if the appropriate env var is set. > Not sure, though, as we squash merge. May require some parsing of the commit message to get co-authors (if needed) as well.
lunny commented 2023-03-17 04:06:21 +00:00 (Migrated from gitea.com)

I would also like to include the PR indexes like mozilla did https://blog.mozilla.org/community/2021/04/16/new-contributors-to-firefox/

I would also like to include the PR indexes like mozilla did https://blog.mozilla.org/community/2021/04/16/new-contributors-to-firefox/
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/changelog#73
No description provided.