lunny/changelog
1
0
Fork 2
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Respect --token argument on github too #79

Merged
6543 merged 3 commits from refs/pull/79/head into main 2023-06-23 17:20:49 +00:00
Conversation 2 Commits 3 Files Changed 1 +16 -10
6543 commented 2023-06-23 12:30:37 +00:00 (Migrated from gitea.com)
Copy Link
No description provided.
jolheiser commented 2023-06-23 13:03:55 +00:00 (Migrated from gitea.com)
Copy Link

Can this code be merged with the httpClient func in functionality?

Can this code be merged with the `httpClient` func in functionality?
6543 commented 2023-06-23 14:08:44 +00:00 (Migrated from gitea.com)
Copy Link

@jolheiser more refactored

@jolheiser more refactored
jolheiser (Migrated from gitea.com) approved these changes 2023-06-23 14:59:35 +00:00
delvh (Migrated from gitea.com) approved these changes 2023-06-23 15:01:34 +00:00
jolheiser (Migrated from gitea.com) reviewed 2023-06-23 15:01:52 +00:00
service/github.go Outdated
@ -194,3 +132,4 @@
cl := http.DefaultClient
if token != "" {
ts := oauth2.StaticTokenSource(
jolheiser (Migrated from gitea.com) commented 2023-06-23 15:01:52 +00:00
Copy Link

This should used the passed in ctx instead.

This should used the passed in `ctx` instead.
Sign in to join this conversation.
Reviewers
No reviewers
jolheiser
delvh
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
lgtm/done

   
lgtm/need 1

   
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm/done
lgtm/need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/changelog#79
No description provided.
Delete Branch "refs/pull/79/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?