lunny/changelog
1
0
Fork 2
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases 5 Wiki Activity

Github support rate limit #85

Merged
lunny merged 4 commits from refs/pull/85/head into main 2024-05-24 05:59:16 +00:00
Conversation 1 Commits 4 Files Changed 12 +81 -35
lunny commented 2024-05-23 13:13:50 +00:00 (Migrated from gitea.com)
Copy Link
No description provided.
delvh (Migrated from gitea.com) reviewed 2024-05-23 15:08:49 +00:00
service/github.go Outdated
delvh (Migrated from gitea.com) commented 2024-05-23 15:08:49 +00:00
Copy Link

Wait, does Go busywait here?
Wouldn't it be better to let it sleep until the timer is over?

Wait, does Go busywait here? Wouldn't it be better to let it sleep until the timer is over?
delvh (Migrated from gitea.com) commented 2024-05-24 01:19:36 +00:00
Copy Link

It will not be busy. There is a timer below this line. So we can terminal the application any time. If we use Sleep here, it cannot be stopped.

It will not be busy. There is a timer below this line. So we can terminal the application any time. If we use Sleep here, it cannot be stopped.
service/github.go Outdated
delvh (Migrated from gitea.com) commented 2024-05-23 15:10:31 +00:00
Copy Link

That's a risky assumption.
It implies that tags don't have a v-prefix.
I wouldn't rely on that.

That's a risky assumption. It implies that tags don't have a `v`-prefix. I wouldn't rely on that.
delvh (Migrated from gitea.com) commented 2024-05-24 01:17:40 +00:00
Copy Link

Hm, yes. It's hacky. But Gitea did that. I have to change the link every time after the generation is completed.

Hm, yes. It's hacky. But Gitea did that. I have to change the link every time after the generation is completed.
lunny commented 2024-05-24 05:59:43 +00:00 (Migrated from gitea.com)
Copy Link

Hm, it's an accident merge.

Hm, it's an accident merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
lgtm/done

   
lgtm/need 1

   
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm/done
lgtm/need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/changelog#85
No description provided.
Delete Branch "refs/pull/85/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?