git-lfs/config/map_fetcher.go

package config

// mapFetcher provides an implementation of the Fetcher interface by wrapping
// the `map[string]string` type.
type mapFetcher map[string]string

func MapFetcher(m map[string]string) Fetcher {
	return mapFetcher(m)
}

// Get implements the func `Fetcher.Get`.
func (m mapFetcher) Get(key string) (val string, ok bool) {
	val, ok = m[key]
	return
}

func (m mapFetcher) All() map[string]string {
	newmap := make(map[string]string)
	for key, value := range m {
		newmap[key] = value
	}
	return newmap
}
config: eradicate uses of SetAllEnv The `SetAllEnv` function is one of two functions that allow for mutable behavior within the `config.Configuration` type. It is desirable for us to remove that function, and all of its uses throughout the LFS codebase. Unfortunately, a lot of `SetAllEnv` uses are coupled to initializing the `config.Configuration` instance with custom `.gitconfig` data, a-la `NewFromValues`. This coupling makes it difficult to write an atomic commit that only* removes the usage of `SetAllEnv`. As a compromise, the signature of `NewFromValues` changed from: ``` func NewFromValues(gitconfig map[string]strimg) Configuration ``` to... ``` type Values struct { Git, Env map[string]string } func NewFrom(v Values) Configuration ``` To support reading fixed data as a part of the `Env` fetcher, a new Fetcher type was introduced: ``` type mapFetcher map[string]string func (m mapFetcher) Get(key string) (val string) { ... } ``` and is used in place of the old `*EnvFetcher` to retrieve data from the "environment". 2016-08-03 23:42:21 +00:00			`package config`

			`// mapFetcher provides an implementation of the Fetcher interface by wrapping`
			// the `map[string]string` type.
			`type mapFetcher map[string]string`

config: remove MockFetcher in tests 2016-08-05 00:58:43 +00:00			`func MapFetcher(m map[string]string) Fetcher {`
			`return mapFetcher(m)`
			`}`

config: eradicate uses of SetAllEnv The `SetAllEnv` function is one of two functions that allow for mutable behavior within the `config.Configuration` type. It is desirable for us to remove that function, and all of its uses throughout the LFS codebase. Unfortunately, a lot of `SetAllEnv` uses are coupled to initializing the `config.Configuration` instance with custom `.gitconfig` data, a-la `NewFromValues`. This coupling makes it difficult to write an atomic commit that only* removes the usage of `SetAllEnv`. As a compromise, the signature of `NewFromValues` changed from: ``` func NewFromValues(gitconfig map[string]strimg) Configuration ``` to... ``` type Values struct { Git, Env map[string]string } func NewFrom(v Values) Configuration ``` To support reading fixed data as a part of the `Env` fetcher, a new Fetcher type was introduced: ``` type mapFetcher map[string]string func (m mapFetcher) Get(key string) (val string) { ... } ``` and is used in place of the old `*EnvFetcher` to retrieve data from the "environment". 2016-08-03 23:42:21 +00:00			// Get implements the func `Fetcher.Get`.
change (Environment) Get()'s signature to include ok bool 2016-08-05 21:59:57 +00:00			`func (m mapFetcher) Get(key string) (val string, ok bool) {`
			`val, ok = m[key]`
			`return`
			`}`
remove AllGitConfig() 2016-11-10 00:33:43 +00:00
			`func (m mapFetcher) All() map[string]string {`
			`newmap := make(map[string]string)`
			`for key, value := range m {`
			`newmap[key] = value`
			`}`
			`return newmap`
			`}`