lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update lfs.go

Browse Source 
Update to clean up the use of the 0755 value in the directory creation code. Also added comment about using the system's umask value in the future to better align created locations with that of the system's admin. Refactoring here should make updates easier in the future.

NOTE: Not sure about the actual syntax of Go and its ability to keep uint32 values true given their assignment as constants.
This commit is contained in:
Thomas S. Pangborn 2015-06-02 23:48:57 -04:00
parent 27ea25e4d2
commit 03a759042e
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lfs/lfs.go
View File

@ -14,6 +14,19 @@ import (
const Version = "0.5.1"
//
// Setup permissions for the given directories used here.
//
// NOTE: Pull these values from the umask value of this
// process in the future. This would ensure the directories
// are created with the same value the Administrator of the
// system had intended without making any assumptions as the
// values do below.
//
const TEMP_DIR_PERMS = 0755
const LOCAL_MEDIA_DIR_PERMS = 0755
const LOCAL_LOG_DIR_PERMS = 0755
var (
LargeSizeThreshold = 5 * 1024 * 1024
TempDir = filepath.Join(os.TempDir(), "git-lfs")
@ -27,7 +40,7 @@ var (
func TempFile(prefix string) (*os.File, error) {
if checkedTempDir != TempDir {
if err := os.MkdirAll(TempDir, 0755); err != nil {
if err := os.MkdirAll(TempDir, TEMP_DIR_PERMS); err != nil {
return nil, err
}
checkedTempDir = TempDir
@ -43,7 +56,7 @@ func ResetTempDir() error {
func LocalMediaPath(sha string) (string, error) {
path := filepath.Join(LocalMediaDir, sha[0:2], sha[2:4])
if err := os.MkdirAll(path, 0755); err != nil {
if err := os.MkdirAll(path, LOCAL_MEDIA_DIR_PERMS); err != nil {
return "", fmt.Errorf("Error trying to create local media directory in '%s': %s", path, err)
}
@ -86,15 +99,15 @@ func init() {
LocalLogDir = filepath.Join(LocalMediaDir, "logs")
TempDir = filepath.Join(LocalGitDir, "lfs", "tmp")
if err := os.MkdirAll(LocalMediaDir, 0755); err != nil {
if err := os.MkdirAll(LocalMediaDir, LOCAL_MEDIA_DIR_PERMS); err != nil {
panic(fmt.Errorf("Error trying to create objects directory in '%s': %s", LocalMediaDir, err))
}
if err := os.MkdirAll(LocalLogDir, 0755); err != nil {
if err := os.MkdirAll(LocalLogDir, LOCAL_LOG_DIR_PERMS); err != nil {
panic(fmt.Errorf("Error trying to create log directory in '%s': %s", LocalLogDir, err))
}
if err := os.MkdirAll(TempDir, 0755); err != nil {
if err := os.MkdirAll(TempDir, TEMP_DIR_PERMS); err != nil {
panic(fmt.Errorf("Error trying to create temp directory in '%s': %s", TempDir, err))
}