lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use batch API for Download, fallback to legacy if unsupported

Browse Source 
The smudge filters still used the direct legacy api via the Download()
function. It should now go through the batch API and only use the legacy
API if the server doesn't support the batch operations.
This commit is contained in:
rubyist 2015-10-06 07:05:58 -04:00
parent f32da15913
commit 1563366464
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lfs/client.go
View File

@ -104,7 +104,28 @@ func (e *ClientError) Error() string {
return msg
}
// Download will attempt to download the object with the given oid. The batched
// API will be used, but if the server does not implement the batch operations
// it will fall back to the legacy API.
func Download(oid string) (io.ReadCloser, int64, error) {
objects := []*objectResource{&objectResource{Oid: oid}}
objs, err := Batch(objects, "download")
if err != nil {
if IsNotImplementedError(err) {
return DownloadLegacy(oid)
}
return nil, 0, err
}
if len(objs) != 1 { // Expecting to find one object
return nil, 0, Error(fmt.Errorf("Object not found: %s", oid))
}
return DownloadObject(objs[0])
}
// DownloadLegacy attempts to download the object for the given oid using the
// legacy API.
func DownloadLegacy(oid string) (io.ReadCloser, int64, error) {
req, err := newApiRequest("GET", oid)
if err != nil {
return nil, 0, Error(err)