lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Makefile: don't fail the second time macOS builds are built

Browse Source 
zip has an interesting feature: if there is nothing to do, it exits 12.
Since in our macOS release CI target, we build the same asset multiple
times due to using two separate invocations of make, we end up with a
case where zip exits 12 unexpectedly.

Ideally make would realize that our assets don't need to be rebuilt, but
as long as we're going to rebuild them, let's remove the existing file
so zip doesn't get bent out of shape about the fact that our operation
isn't doing anything useful.
This commit is contained in:
brian m. carlson 2020-12-10 21:57:53 +00:00
parent 2ceecc039b
commit 2e8e75c757
No known key found for this signature in database
GPG Key ID: 2D0C9BC12F82B3A1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile
View File

@ -318,6 +318,7 @@ $(RELEASE_INCLUDES) bin/git-lfs-% script/install.sh
bin/releases/git-lfs-darwin-%-$(VERSION).zip : \
$(RELEASE_INCLUDES) bin/git-lfs-darwin-% script/install.sh
dir=bin/releases/darwin-$* && \
rm -f $@ && \
mkdir -p $$dir && \
cp -R $^ $$dir && mv $$dir/git-lfs-darwin-$* $$dir/git-lfs && \
zip -j $@ $$dir/* && \