lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

t/t-fsck.sh: add invalid objects test

Browse Source 
Although we have a number of tests of the "git lfs fsck --pointers"
option added in PR #4525, we do not yet have any of the companion
"git lfs fsck --objects" option.  We therefore add a pair of tests,
one of checking for expected output when Git LFS object files are
corrupt or missing, and one checking for no output when no Git LFS
objects exist in the repository.

Note that at present we expect an exit code of 2, not 1, when the
"git lfs fsck --objects" command is unable to move a completely
missing Git LFS object file to the .git/lfs/bad directory.  We
expect to revise this behaviour and the relevant exit code checks
in a subsequent commit.
This commit is contained in:
Chris Darroch 2022-02-05 20:29:36 -08:00
parent 12a9572029
commit 325fb173a3
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
t/t-fsck.sh
View File

@ -264,6 +264,72 @@ EOF
)
end_test
setup_invalid_objects () {
git init $reponame
cd $reponame
# Create a commit with some files tracked by git-lfs
git lfs track *.dat
echo "test data" > a.dat
echo "test data 2" > b.dat
git add .gitattributes *.dat
git commit -m "first commit"
oid1=$(calc_oid_file a.dat)
oid2=$(calc_oid_file b.dat)
echo "CORRUPTION" >>".git/lfs/objects/${oid1:0:2}/${oid1:2:2}/$oid1"
rm ".git/lfs/objects/${oid2:0:2}/${oid2:2:2}/$oid2"
}
begin_test "fsck detects invalid objects"
(
set -e
reponame="fsck-objects"
setup_invalid_objects
set +e
git lfs fsck >test.log 2>&1
RET=$?
set -e
[ "$RET" -eq 2 ]
[ $(grep -c 'objects: corruptObject: a.dat (.*) is corrupt' test.log) -eq 1 ]
[ $(grep -c 'objects: openError: b.dat (.*) could not be checked: .*' test.log) -eq 1 ]
[ $(grep -c 'objects: repair: moving corrupt objects to .*' test.log) -eq 1 ]
cd ..
rm -rf $reponame
setup_invalid_objects
set +e
git lfs fsck --objects >test.log 2>&1
RET=$?
set -e
[ "$RET" -eq 2 ]
[ $(grep -c 'objects: corruptObject: a.dat (.*) is corrupt' test.log) -eq 1 ]
[ $(grep -c 'objects: openError: b.dat (.*) could not be checked: .*' test.log) -eq 1 ]
[ $(grep -c 'objects: repair: moving corrupt objects to .*' test.log) -eq 1 ]
)
end_test
begin_test "fsck does not detect invalid objects with no LFS objects"
(
set -e
reponame="fsck-objects-none"
git init "$reponame"
cd "$reponame"
echo "# README" > README.md
git add README.md
git commit -m "Add README"
git lfs fsck
git lfs fsck --objects
)
end_test
begin_test "fsck operates on specified refs"
(
set -e