don't return any empty creds

This commit is contained in:
risk danger olson 2015-11-17 18:29:55 -07:00
parent da37a83741
commit 47725d0445

@ -181,7 +181,7 @@ func execCredsCommand(input Creds, subCommand string) (Creds, error) {
// 'git credential' exits with 128 if the helper doesn't fill the username
// and password values.
if subCommand == "fill" && err.Error() == "exit status 128" {
return input, nil
return nil, nil
}
}
@ -192,7 +192,7 @@ func execCredsCommand(input Creds, subCommand string) (Creds, error) {
creds := make(Creds)
for _, line := range strings.Split(output.String(), "\n") {
pieces := strings.SplitN(line, "=", 2)
if len(pieces) < 2 {
if len(pieces) < 2 || len(pieces[1]) < 1 {
continue
}
creds[pieces[0]] = pieces[1]