lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

githistory: keep track of updated refs

Browse Source 
Keep track of which refs we've already processed and which we haven't,
and skip processing a ref a second time if we've already seen it. This
isn't a problem now, but it will be in a future commit, so guard against
it.
This commit is contained in:
brian m. carlson 2019-06-21 17:12:04 +00:00
parent 07c787d048
commit 92cb839cf9
No known key found for this signature in database
GPG Key ID: 2D0C9BC12F82B3A1
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
git/githistory/ref_updater.go
View File

@ -47,9 +47,9 @@ func (r *refUpdater) UpdateRefs() error {
maxNameLen = tools.MaxInt(maxNameLen, len(ref.Name))
}
seen := make(map[string]struct{})
for _, ref := range r.Refs {
err := r.updateOneRef(list, maxNameLen, ref)
if err != nil {
if err := r.updateOneRef(list, maxNameLen, seen, ref); err != nil {
return err
}
}
@ -57,12 +57,17 @@ func (r *refUpdater) UpdateRefs() error {
return nil
}
func (r *refUpdater) updateOneRef(list *tasklog.ListTask, maxNameLen int, ref *git.Ref) error {
func (r *refUpdater) updateOneRef(list *tasklog.ListTask, maxNameLen int, seen map[string]struct{}, ref *git.Ref) error {
sha1, err := hex.DecodeString(ref.Sha)
if err != nil {
return errors.Wrapf(err, "could not decode: %q", ref.Sha)
}
if _, ok := seen[ref.Name]; ok {
return nil
}
seen[ref.Name] = struct{}{}
to, ok := r.CacheFn(sha1)
if ref.Type == git.RefTypeLocalTag {