httpTransportFor() is only used once

This commit is contained in:
Rick Olson 2015-03-05 11:49:21 -07:00
parent a916c95276
commit b8ad7ba5c6

@ -39,18 +39,12 @@ func (c *Configuration) HttpClient() *http.Client {
func (c *Configuration) RedirectingHttpClient() *http.Client { func (c *Configuration) RedirectingHttpClient() *http.Client {
if c.redirectingHttpClient == nil { if c.redirectingHttpClient == nil {
c.redirectingHttpClient = &http.Client{ tr := &http.Transport{}
Transport: httpTransportFor(c), sslVerify, _ := c.GitConfig("http.sslverify")
if sslVerify == "false" || len(os.Getenv("GIT_SSL_NO_VERIFY")) > 0 {
tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
} }
c.redirectingHttpClient = &http.Client{Transport: tr}
} }
return c.redirectingHttpClient return c.redirectingHttpClient
} }
func httpTransportFor(c *Configuration) *http.Transport {
tr := &http.Transport{}
sslVerify, _ := c.GitConfig("http.sslverify")
if len(os.Getenv("GIT_SSL_NO_VERIFY")) > 0 || sslVerify == "false" {
tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
}
return tr
}