lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't download on smudge if file is filtered by include/exclude config

Browse Source
This commit is contained in:
Steve Streeting 2015-08-10 16:57:13 +01:00
parent 6f847ea527
commit bf8bade4cf
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
commands/command_smudge.go
View File

@ -57,7 +57,9 @@ func smudgeCommand(cmd *cobra.Command, args []string) {
Error(err.Error())
}
err = ptr.Smudge(os.Stdout, filename, true, cb)
cfg := lfs.Config
download := lfs.FilenamePassesIncludeExcludeFilter(filename, cfg.FetchIncludePaths(), cfg.FetchExcludePaths())
err = ptr.Smudge(os.Stdout, filename, download, cb)
if file != nil {
file.Close()
}

30
test/test-smudge.sh
View File

@ -46,3 +46,33 @@ begin_test "smudge with invalid pointer"
[ "wat" = "$(echo "wat" | git lfs smudge)" ]
)
end_test
begin_test "smudge include/exclude"
(
set -e
reponame="smudge_includeexclude"
setup_remote_repo "$reponame"
clone_repo "$reponame" repoincludeexclude
git lfs track "*.dat"
echo "smudge a" > a.dat
git add .gitattributes a.dat
git commit -m "add a.dat"
# smudge works even though it hasn't been pushed, by reading from .git/lfs/objects
output="$(pointer fcf5015df7a9089a7aa7fe74139d4b8f7d62e52d5a34f9a87aeffc8e8c668254 9 | git lfs smudge)"
[ "smudge a" = "$output" ]
git push origin master
# this WOULD download except we're going to prevent it with include/exclude
rm -rf .git/lfs/objects
git config "lfs.fetchexclude" "a*"
output="$(pointer fcf5015df7a9089a7aa7fe74139d4b8f7d62e52d5a34f9a87aeffc8e8c668254 9 | git lfs smudge a.dat)"
# because download was not allowed, contents will be a pointer ie unchanged
[ "$(pointer fcf5015df7a9089a7aa7fe74139d4b8f7d62e52d5a34f9a87aeffc8e8c668254 9)" = "$output" ]
)
end_test