lunny/git-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove a few todos

Browse Source
This commit is contained in:
Lars Schneider 2016-11-08 15:24:03 +01:00
parent 9bacfdf90c
commit c7cb4dc7df
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
git/filter_protocol.go
View File

@ -117,7 +117,6 @@ func (p *protocol) writeFlush() error {
} }
func (p *protocol) writePacketText(data string) error { func (p *protocol) writePacketText(data string) error {
//TODO: there is probably a more efficient way to do this. worth it?
return p.writePacket([]byte(data + "\n")) return p.writePacket([]byte(data + "\n"))
} }

3
git/git_filter_protocol.go
View File

@ -16,7 +16,6 @@ const (
) )
// Private function copied from "github.com/xeipuuv/gojsonschema/utils.go" // Private function copied from "github.com/xeipuuv/gojsonschema/utils.go"
// TODO: Is there a way to reuse this?
func isStringInSlice(s []string, what string) bool { func isStringInSlice(s []string, what string) bool {
for i := range s { for i := range s {
if s[i] == what { if s[i] == what {
@ -115,7 +114,7 @@ func (o *ObjectScanner) WriteResponse(outputData []byte) error {
o.p.writeFlush() o.p.writeFlush()
break break
} else if chunkSize > MaxPacketLength { } else if chunkSize > MaxPacketLength {
chunkSize = MaxPacketLength // TODO check packets with the exact size chunkSize = MaxPacketLength
} }
err := o.p.writePacket(outputData[:chunkSize]) err := o.p.writePacket(outputData[:chunkSize])
if err != nil { if err != nil {