Commit Graph

29 Commits

Author SHA1 Message Date
brian m. carlson
9a51ea0f46
Pass environment variables into object scanner
We're going to need the environment variables in the object scanner, so
pass the appropriate Environment instance down into the object scanner.
Use an interface to avoid an import loop between the git and config
packages.

Note that the environment is not yet used, but will be in a future
commit.
2019-08-15 17:39:32 +00:00
brian m. carlson
16857d83d7
lfs: detect errors when object scanner fails
Much as in 7dae4954 ("lfs: don't close pointer scanner on error",
2018-11-16), don't close the pointer scanner on error when running git
cat-file --batch, either. This ensures we report errors to the user when
we stop scanning and avoids a deadlock.
2019-01-15 18:53:09 +00:00
rick olson
d039e3791a lfs: PointerScanner is nil after error, so don't close 2017-10-27 14:26:02 -06:00
Taylor Blau
620218f9c0 commands,lfs: prevent leaking git cat-file --batch from *git.ObjectScanner 2017-04-27 14:37:28 -06:00
Taylor Blau
2e7646b98b lfs: rename CatFileBatchScanner to PointerScanner 2017-04-04 14:35:03 -06:00
Taylor Blau
1799d1b0f1 lfs: remove some unneeded debugging information 2017-04-04 14:30:10 -06:00
Taylor Blau
fb9145c094 lfs/gitscanner: use git.ObjectScanner in CatFileBatchScanner 2017-04-04 14:14:19 -06:00
Taylor Blau
b51d64941b lfs/catfilebatch: make Scan() take a string instead of []byte 2017-03-23 12:02:35 -06:00
Taylor Blau
844c0b0db2 lfs/catfilebatch: don't read large blobs into memory 2017-03-23 11:55:40 -06:00
Taylor Blau
90c474979c lfs: implement CatFileBatchScanner.ContentsSha() 2017-03-23 10:07:34 -06:00
Taylor Blau
f0ccaf88a2 lfs: make CatFileBatchScanner public 2017-03-23 10:07:34 -06:00
risk danger olson
08c5ae6c64 lfs: teach gitscanner how to emit lockable files that aren't lfs objects 2017-02-16 16:52:40 -07:00
risk danger olson
ed8bb8f9a9 code review tweaks 2016-11-21 09:20:18 -07:00
risk danger olson
867d9f5bb8 bring the golang scanner pattern back 2016-11-18 17:00:57 -07:00
risk danger olson
558da776d9 update runCatFileBatchCheck() too 2016-11-18 15:56:29 -07:00
risk danger olson
5dc3c9c70e update runCatFileBatch() to use just a single goroutine for stdin + stdout 2016-11-18 15:35:51 -07:00
risk danger olson
79a50b2873 use similar scanner.Next() convention, clean up tests 2016-11-18 15:26:29 -07:00
risk danger olson
152e017fed favor Next() 2016-11-18 14:55:19 -07:00
risk danger olson
c7833ab6ca use the scanner in catFileBatchTree() 2016-11-18 14:20:51 -07:00
risk danger olson
e96b53dae9 unnecessary colon for wrap message 2016-11-18 14:00:30 -07:00
risk danger olson
3f562f6058 Merge branch 'master' into gitscanner-exported-api 2016-11-18 11:35:09 -07:00
risk danger olson
a8a5b10d7b read all of the bytes 2016-11-18 09:09:52 -07:00
risk danger olson
c9162b6915 remove WrappedPointer Size, since it embeds Pointer 2016-11-17 17:55:06 -07:00
risk danger olson
3afd91a3f1 need to check for --batch-check errors before closing stdin 2016-11-16 11:39:08 -07:00
risk danger olson
eec6affd50 handle io.EOF properly 2016-11-16 11:04:28 -07:00
risk danger olson
1da3bbb990 put the scanner at the bottom 2016-11-15 15:15:37 -07:00
risk danger olson
c0da360f53 extract a scanner 2016-11-15 15:14:52 -07:00
risk danger olson
bd8ce51e80 git catfilebatch: pr feedback 2016-11-15 14:41:41 -07:00
risk danger olson
01e9e59a91 rewrite new catfilebatch implementation for upcoming gitscanner pkg 2016-11-14 11:56:06 -07:00