Since we're about to do a v3.0.0 release, let's bump the version to v3.
Make this change automatically with the following command to avoid any
missed items:
git grep -l github.com/git-lfs/git-lfs/v2 | \
xargs sed -i -e 's!github.com/git-lfs/git-lfs/v2!github.com/git-lfs/git-lfs/v3!g'
When our go.mod file was introduced in commit
114e85c2002091eb415040923d872f8e4a4bc636 in PR #3208, the module
path chosen did not include a trailing /v2 component. However,
the Go modules specification now advises that module paths must
have a "major version suffix" which matches the release version.
We therefore add a /v2 suffix to our module path and all its
instances in import paths.
See also https://golang.org/ref/mod#major-version-suffixes for
details regarding the Go module system's major version suffix rule.
When we look up the repository path from Git, we pass it through cygpath
-w to canonicalize it into a Windows path, since Cygwin's Git will give
us a Unix-style path. We perform path canonicalization not only on
Cygwin, but also on MINGW as well, which include Git Bash, since we want
to accept and canonicalize Unix-style paths there as well.
Normally, this works great. However, if invoked not from Git Bash, but
via the Git for Windows bash.exe command, no locale is set in the
environment, despite the locale binary indicating UTF-8 locales. As a
result, if non-ASCII character exist in the path name, it tries to
encode them in ISO-8850-1.
On a standard Unix, where paths are always bytes, defaulting to
ISO-8859-1 might be fine, because regardless of the encoding, paths are
always bytes and no encoding needs to be performed. On macOS, where the
file system and all locales use UTF-8, this is also not a problem,
because again, no encoding needs to be done.
However, on Windows, where paths are natively stored as UTF-16, this is
remarkably unhelpful, since the majority of Unicode code points cannot
be represented in ISO-8859-1. Thus, the vast majority of paths are
broken by cygpath when the locale is not set.
Since we know we always want UTF-8 from cygpath, let's just force that
in the environment we pass it. We need to copy the environment since
the value we have is shared among all executed subcommands and we don't
want to modify other commands' locales, since that would cause error
messages to be printed in English instead of the user's locale.
Note that before this change, the test would fail because the local
working directory was not read, and therefore it would be empty on
Windows.
It looks like there are situations in which some Git for Windows
installations don't have the cygpath binary. In that case, we end up
picking an empty string, which leads us to install hooks and LFS objects
in the current directory. Fix this by trying cygpath, and if it fails
due to a path lookup error, returning the original path as we got it.
