Commit Graph

6 Commits

Author SHA1 Message Date
Marat Radchenko
482260c7e3 Fix error strings to follow Go guidelines
Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation:
https://github.com/golang/go/wiki/CodeReviewComments#error-strings
2019-10-22 17:33:49 +03:00
Taylor Blau
b3a4e843ca git/pl: document pkt-line behavior 2016-11-15 14:35:21 -07:00
Taylor Blau
f89c31bae4 git/pl: flush underlying *bufio.Writer only when necessary
Previously, we flushed intermediate data out of the underlying *bufio.Writer
used by the implementation of `pkt-line` in `*git.pktline` after _every_ write.
This means that we would flush after partial packets, whole packets, and after
pkt-line flush sequences. This is unnecessary.

Let us instead flush only after an entire packet has been written, after
writing the `0000` flush sequence.

/ref git-lfs/git-lfs#1640
2016-11-15 14:35:21 -07:00
Taylor Blau
63f541833c git: annotate the presence of a flush packet 2016-11-10 12:27:38 -07:00
Taylor Blau
e63083c61a git/fps: 💅 2016-11-08 18:41:15 -07:00
Taylor Blau
03960d9c28 git: rename *protocol to *pktline 2016-11-08 14:13:05 -07:00