Currently, our default branch in tests is "master". This is the Git
default, but the Git default will likely change in the future, so it
makes sense to update our testsuite to be explicit about the branch
name. We'll ensure this continues by building against older versions of
Git as well as newer versions.
We use "main" for the new branch name, since that's the proposed value
upstream.
This commit was made entirely by automated means using the following
command:
git grep -l master t | xargs sed -i -e 's/master/main/g'
It's possible that the final "Downloading objects" message might not be
printed in some cases due to a race condition. (The corresponding
upload message, on the other hand, will always be printed because it
runs before the actual push.)
To avoid spurious failures, don't look for this message in several tests
where this race condition commonly occurs. Instead, use "git lfs fsck"
to verify that we downloaded all the objects we expected to get.
In addition, several of the tests also check that the expected number of
objects is correct, which provides additional confidence that our test
did in fact succeed.
When a custom transfer adapter is specified in the configuration, it is
not possible to specify multiple arguments to the process, because only
the last value of the lfs.customtransfer.*.args option is read and the
value is not split. To make things easier and more flexible,
concatenate the path (after quoting) and the arguments and pass them to
the shell. Update the documentation to reflect this change.
Update the test custom transfer adapter to parse its arguments (which
are otherwise ignored) and mention them to standard error. Make the
test check that the arguments are parsed as the shell would expect them
to be.
The printf(1) command, like it's C cousin, takes a format string as its
first argument. If a shell variable is passed as the first argument, it
will be interpreted as a format string; this can lead to surprising
behavior and can cause the test suite to fail if we accidentally insert
a format string character into the variable.
Modify all the places in the individual tests that we use a plain quoted
variable as the format string by running the following Ruby one-liner:
ruby -i -pe '$_.gsub!(/printf "\$/, %q(printf "%s" "$))' t/t-*.sh
Avoid modifying the test helpers, as there are places (such as calc_oid)
where we want to pass text containing escapes (such as "\n") and have
those be properly interpreted by printf(1).
