0c8edfc097
On Windows, there is no way to replace file atomically. Instead, MoveFileExA: 1. Calls CreateFileA(access=Delete, shareMode=Delete) 2. Calls SetRenameInformationFile to rename file 3. Calls CloseFile The problem is that if parallel process attempts to open destination file for reading between steps 2 and 3, it will try to do that without shareMode=Delete and will hit a SHARING_VIOLATION error. In practice, this race condition results in: Smudge error: Error opening media file.: open .git\lfs\objects\<sha>: The process cannot access the file because it is being used by another process. There are two solutions here: 1. Do not overwrite file if it already exists 2. Retry reading from file if got a SHARING_VIOLATION This commit implements option 1. Fixes #2825 (for Windows, other OSes are race-free already). Also see #3813 and #3826.
78 lines
1.7 KiB
Go
78 lines
1.7 KiB
Go
// +build linux,cgo
|
|
|
|
package tools
|
|
|
|
/*
|
|
#include <sys/ioctl.h>
|
|
|
|
#undef FICLONE
|
|
#define FICLONE _IOW(0x94, 9, int)
|
|
// copy from https://github.com/torvalds/linux/blob/v5.2/include/uapi/linux/fs.h#L195 for older header files.
|
|
// This is equal to the older BTRFS_IOC_CLONE value.
|
|
*/
|
|
import "C"
|
|
|
|
import (
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"syscall"
|
|
)
|
|
|
|
const (
|
|
ioctlFiClone = C.FICLONE
|
|
)
|
|
|
|
// CheckCloneFileSupported runs explicit test of clone file on supplied directory.
|
|
// This function creates some (src and dst) file in the directory and remove after test finished.
|
|
//
|
|
// If check failed (e.g. directory is read-only), returns err.
|
|
func CheckCloneFileSupported(dir string) (supported bool, err error) {
|
|
src, err := ioutil.TempFile(dir, "src")
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
defer os.Remove(src.Name())
|
|
|
|
dst, err := ioutil.TempFile(dir, "dst")
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
defer os.Remove(dst.Name())
|
|
|
|
if ok, err := CloneFile(dst, src); err != nil {
|
|
return false, err
|
|
} else {
|
|
return ok, nil
|
|
}
|
|
}
|
|
|
|
func CloneFile(writer io.Writer, reader io.Reader) (bool, error) {
|
|
fdst, fdstFound := writer.(*os.File)
|
|
fsrc, fsrcFound := reader.(*os.File)
|
|
if fdstFound && fsrcFound {
|
|
if _, _, err := syscall.Syscall(syscall.SYS_IOCTL, fdst.Fd(), ioctlFiClone, fsrc.Fd()); err != 0 {
|
|
return false, err
|
|
}
|
|
return true, nil
|
|
}
|
|
return false, nil
|
|
}
|
|
|
|
func CloneFileByPath(dst, src string) (bool, error) {
|
|
srcFile, err := os.Open(src)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
dstFile, err := os.Create(dst) //truncating, it if it already exists.
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
return CloneFile(dstFile, srcFile)
|
|
}
|
|
|
|
func TryRename(oldname, newname string) error {
|
|
return RenameFileCopyPermissions(oldname, newname)
|
|
}
|