git-lfs/t/t-filter-process.sh
brian m. carlson 56b18085ab
smudge: honor GIT_LFS_SKIP_SMUDGE with checkout-index
In most cases, users use a relatively modern version of Git which
supports the filter-process code and delayed smudging.  This is valuable
because it makes things much faster. However, it also uses a different
code path from the non-delayed path. This non-delayed path is also used
by git checkout-index.

The non-delayed path doesn't work properly, however, if the data is
already on disk.  In such a case, we simply ask the smudge filter not to
download the data, but since it's already on disk, we feed it out
anyway.

Let's solve this by simply not invoking the filter and emitting the
pointer if we've asked to skip.  We do the same thing if the file
doesn't match the filter, since the comment at the top of the function
states that's what's supposed to happen here as well.

Once we've done that, the variable download is always true, so remove
all the code which considers that it might be false to simplify the code
somewhat.
2022-02-07 19:22:02 +00:00

190 lines
4.5 KiB
Bash
Executable File

#!/usr/bin/env bash
. "$(dirname "$0")/testlib.sh"
# HACK(taylor): git uses ".g<hash>" in the version name to signal that it is
# from the "next" branch, which is the only (current) version of Git that has
# support for the filter protocol.
#
ensure_git_version_isnt $VERSION_LOWER "2.11.0"
begin_test "filter process: checking out a branch"
(
set -e
reponame="filter_process_checkout"
setup_remote_repo "$reponame"
clone_repo "$reponame" repo
git lfs track "*.dat"
git add .gitattributes
git commit -m "initial commit"
contents_a="contents_a"
contents_a_oid="$(calc_oid $contents_a)"
printf "%s" "$contents_a" > a.dat
git add a.dat
git commit -m "add a.dat"
git checkout -b b
contents_b="contents_b"
contents_b_oid="$(calc_oid $contents_b)"
printf "%s" "$contents_b" > b.dat
git add b.dat
git commit -m "add b.dat"
git push origin --all
pushd ..
# Git will choose filter.lfs.process over `filter.lfs.clean` and
# `filter.lfs.smudge`
GIT_TRACE_PACKET=1 git \
-c "filter.lfs.process=git-lfs filter-process" \
-c "filter.lfs.clean=false"\
-c "filter.lfs.smudge=false" \
-c "filter.lfs.required=true" \
clone "$GITSERVER/$reponame" "$reponame-assert"
cd "$reponame-assert"
# Assert that we are on the "main" branch, and have a.dat
[ "main" = "$(git rev-parse --abbrev-ref HEAD)" ]
[ "$contents_a" = "$(cat a.dat)" ]
assert_pointer "main" "a.dat" "$contents_a_oid" 10
git checkout b
# Assert that we are on the "b" branch, and have b.dat
[ "b" = "$(git rev-parse --abbrev-ref HEAD)" ]
[ "$contents_b" = "$(cat b.dat)" ]
assert_pointer "b" "b.dat" "$contents_b_oid" 10
popd
)
end_test
begin_test "filter process: adding a file"
(
set -e
reponame="filter_process_add"
setup_remote_repo "$reponame"
clone_repo "$reponame" "$reponame"
git lfs track "*.dat"
git add .gitattributes
git commit -m "initial commit"
contents="contents"
contents_oid="$(calc_oid "$contents")"
printf "%s" "$contents" > a.dat
git add a.dat
expected="$(pointer "$contents_oid" "${#contents}")"
got="$(git cat-file -p :a.dat)"
diff -u <(echo "$expected") <(echo "$got")
)
end_test
# https://github.com/git-lfs/git-lfs/issues/1697
begin_test "filter process: add a file with 1024 bytes"
(
set -e
mkdir repo-issue-1697
cd repo-issue-1697
git init
git lfs track "*.dat"
dd if=/dev/zero of=first.dat bs=1024 count=1
printf "any contents" > second.dat
git add .
)
end_test
begin_test "filter process: hash-object --stdin --path does not hang"
(
set -e
mkdir repo-hash-object
cd repo-hash-object
git init
git lfs track "*.dat"
contents="test"
contents_oid="$(calc_oid "$contents")"
expected=$(pointer "$contents_oid" 4 | git hash-object --stdin)
dd if=/dev/zero of=first.dat bs=1000 count=1
echo a > second.dat
# Works for existing file longer than this one.
output=$(printf test | git hash-object --path first.dat --stdin)
[ "$expected" = "$output" ]
# Works for existing file shorter than this one.
output=$(printf test | git hash-object --path second.dat --stdin)
[ "$expected" = "$output" ]
# Works for absent file.
output=$(printf test | git hash-object --path third.dat --stdin)
[ "$expected" = "$output" ]
dd if=/dev/zero of=large.dat bs=65537 count=1
oid=$(calc_oid_file large.dat)
expected=$(pointer "$oid" 65537 | git hash-object --stdin)
output=$(git hash-object --path third.dat --stdin <large.dat)
[ "$expected" = "$output" ]
git add .
)
end_test
begin_test "filter process: checking out a branch with --skip-smudge and checkout-index"
(
set -e
reponame="filter-process-skip-smudge-checkout-index"
setup_remote_repo "$reponame"
clone_repo "$reponame" "$reponame"
git lfs track "*.dat"
git add .gitattributes
git commit -m "initial commit"
contents_a="contents_a"
contents_a_oid="$(calc_oid $contents_a)"
printf "%s" "$contents_a" > a.dat
git add a.dat
git commit -m "add a.dat"
git checkout -b b
contents_b="contents_b"
contents_b_oid="$(calc_oid $contents_b)"
printf "%s" "$contents_b" > b.dat
git add b.dat
git commit -m "add b.dat"
git lfs install --local --skip-smudge
git checkout main
rm a.dat
git checkout-index -af
git lfs pointer --check --file a.dat
assert_pointer "main" "a.dat" "$contents_a_oid" 10
git checkout b
rm *.dat
git checkout-index -af
git lfs pointer --check --file a.dat
git lfs pointer --check --file b.dat
# Assert that we are on the "b" branch, and have b.dat
assert_pointer "b" "b.dat" "$contents_b_oid" 10
)
end_test