git-lfs/git/gitattr/attr_test.go
Taylor Blau 5a54097c4b git/gitattr/attr{,_test}.go: parse implicitly 'true' attributes
When an attribute does not start with '!', '-', or contain an '=', we
had previously treated it as malformed. Instead, assume that it is a
'set' attribute, which we interpret to mean as being set implicitly to
"true" (and therefore the dual of the '-' prefix).

From the relevant documentation [1]:

  Set
    The path has the attribute with special value "true"; this is
    specified by listing only the name of the attribute in the attribute
    list.

[1]: https://git-scm.com/docs/gitattributes
2018-09-15 20:27:20 -04:00

141 lines
4.0 KiB
Go

package gitattr
import (
"fmt"
"strings"
"testing"
"github.com/stretchr/testify/assert"
)
func TestParseLines(t *testing.T) {
lines, err := ParseLines(strings.NewReader("*.dat filter=lfs"))
assert.NoError(t, err)
assert.Len(t, lines, 1)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Equal(t, lines[0].Attrs[0], &Attr{
K: "filter", V: "lfs",
})
}
func TestParseLinesManyAttrs(t *testing.T) {
lines, err := ParseLines(strings.NewReader(
"*.dat filter=lfs diff=lfs merge=lfs -text crlf"))
assert.NoError(t, err)
assert.Len(t, lines, 1)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Len(t, lines[0].Attrs, 5)
assert.Equal(t, lines[0].Attrs[0], &Attr{K: "filter", V: "lfs"})
assert.Equal(t, lines[0].Attrs[1], &Attr{K: "diff", V: "lfs"})
assert.Equal(t, lines[0].Attrs[2], &Attr{K: "merge", V: "lfs"})
assert.Equal(t, lines[0].Attrs[3], &Attr{K: "text", V: "false"})
assert.Equal(t, lines[0].Attrs[4], &Attr{K: "crlf", V: "true"})
}
func TestParseLinesManyLines(t *testing.T) {
lines, err := ParseLines(strings.NewReader(strings.Join([]string{
"*.dat filter=lfs diff=lfs merge=lfs -text",
"*.jpg filter=lfs diff=lfs merge=lfs -text",
"# *.pdf filter=lfs diff=lfs merge=lfs -text",
"*.png filter=lfs diff=lfs merge=lfs -text",
"*.txt text"}, "\n")))
assert.NoError(t, err)
assert.Len(t, lines, 4)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Equal(t, lines[1].Pattern.String(), "*.jpg")
assert.Equal(t, lines[2].Pattern.String(), "*.png")
assert.Equal(t, lines[3].Pattern.String(), "*.txt")
assert.Len(t, lines[0].Attrs, 4)
assert.Equal(t, lines[0].Attrs[0], &Attr{K: "filter", V: "lfs"})
assert.Equal(t, lines[0].Attrs[1], &Attr{K: "diff", V: "lfs"})
assert.Equal(t, lines[0].Attrs[2], &Attr{K: "merge", V: "lfs"})
assert.Equal(t, lines[0].Attrs[3], &Attr{K: "text", V: "false"})
assert.Len(t, lines[1].Attrs, 4)
assert.Equal(t, lines[1].Attrs[0], &Attr{K: "filter", V: "lfs"})
assert.Equal(t, lines[1].Attrs[1], &Attr{K: "diff", V: "lfs"})
assert.Equal(t, lines[1].Attrs[2], &Attr{K: "merge", V: "lfs"})
assert.Equal(t, lines[1].Attrs[3], &Attr{K: "text", V: "false"})
assert.Len(t, lines[2].Attrs, 4)
assert.Equal(t, lines[2].Attrs[0], &Attr{K: "filter", V: "lfs"})
assert.Equal(t, lines[2].Attrs[1], &Attr{K: "diff", V: "lfs"})
assert.Equal(t, lines[2].Attrs[2], &Attr{K: "merge", V: "lfs"})
assert.Equal(t, lines[2].Attrs[3], &Attr{K: "text", V: "false"})
assert.Len(t, lines[3].Attrs, 1)
assert.Equal(t, lines[3].Attrs[0], &Attr{K: "text", V: "true"})
}
func TestParseLinesUnset(t *testing.T) {
lines, err := ParseLines(strings.NewReader("*.dat -filter"))
assert.NoError(t, err)
assert.Len(t, lines, 1)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Equal(t, lines[0].Attrs[0], &Attr{
K: "filter", V: "false",
})
}
func TestParseLinesUnspecified(t *testing.T) {
lines, err := ParseLines(strings.NewReader("*.dat !filter"))
assert.NoError(t, err)
assert.Len(t, lines, 1)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Equal(t, lines[0].Attrs[0], &Attr{
K: "filter", Unspecified: true,
})
}
func TestParseLinesQuotedPattern(t *testing.T) {
lines, err := ParseLines(strings.NewReader(
"\"space *.dat\" filter=lfs"))
assert.NoError(t, err)
assert.Len(t, lines, 1)
assert.Equal(t, lines[0].Pattern.String(), "space *.dat")
assert.Equal(t, lines[0].Attrs[0], &Attr{
K: "filter", V: "lfs",
})
}
func TestParseLinesCommented(t *testing.T) {
lines, err := ParseLines(strings.NewReader(
"# \"space *.dat\" filter=lfs"))
assert.NoError(t, err)
assert.Len(t, lines, 0)
}
func TestParseLinesUnbalancedQuotes(t *testing.T) {
const text = "\"space *.dat filter=lfs"
lines, err := ParseLines(strings.NewReader(text))
assert.Empty(t, lines)
assert.EqualError(t, err, fmt.Sprintf(
"git/gitattr: unbalanced quote: %s", text))
}
func TestParseLinesWithNoAttributes(t *testing.T) {
lines, err := ParseLines(strings.NewReader("*.dat"))
assert.Len(t, lines, 1)
assert.NoError(t, err)
assert.Equal(t, lines[0].Pattern.String(), "*.dat")
assert.Empty(t, lines[0].Attrs)
}