b2ddccd90d
The printf(1) command, like it's C cousin, takes a format string as its first argument. If a shell variable is passed as the first argument, it will be interpreted as a format string; this can lead to surprising behavior and can cause the test suite to fail if we accidentally insert a format string character into the variable. Modify all the places in the individual tests that we use a plain quoted variable as the format string by running the following Ruby one-liner: ruby -i -pe '$_.gsub!(/printf "\$/, %q(printf "%s" "$))' t/t-*.sh Avoid modifying the test helpers, as there are places (such as calc_oid) where we want to pass text containing escapes (such as "\n") and have those be properly interpreted by printf(1).
34 lines
748 B
Bash
Executable File
34 lines
748 B
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
. "$(dirname "$0")/testlib.sh"
|
|
|
|
begin_test "ssh with proxy command in lfs.url"
|
|
(
|
|
set -e
|
|
|
|
reponame="batch-ssh-proxy"
|
|
setup_remote_repo "$reponame"
|
|
clone_repo "$reponame" "$reponame"
|
|
|
|
sshurl="${GITSERVER/http:\/\//ssh://-oProxyCommand=ssh-proxy-test/}/$reponame"
|
|
echo $sshurl
|
|
git config lfs.url "$sshurl"
|
|
|
|
contents="test"
|
|
oid="$(calc_oid "$contents")"
|
|
git lfs track "*.dat"
|
|
printf "%s" "$contents" > test.dat
|
|
git add .gitattributes test.dat
|
|
git commit -m "initial commit"
|
|
|
|
git push origin master 2>&1 | tee push.log
|
|
if [ "0" -eq "${PIPESTATUS[0]}" ]; then
|
|
echo >&2 "fatal: push succeeded"
|
|
exit 1
|
|
fi
|
|
|
|
grep "got 4 args" push.log
|
|
grep "lfs-ssh-echo -- -oProxyCommand" push.log
|
|
)
|
|
end_test
|