git-lfs/t/t-expired.sh
brian m. carlson b2ddccd90d t: avoid using shell variables in printf's first argument
The printf(1) command, like it's C cousin, takes a format string as its
first argument.  If a shell variable is passed as the first argument, it
will be interpreted as a format string; this can lead to surprising
behavior and can cause the test suite to fail if we accidentally insert
a format string character into the variable.

Modify all the places in the individual tests that we use a plain quoted
variable as the format string by running the following Ruby one-liner:

  ruby -i -pe '$_.gsub!(/printf "\$/, %q(printf "%s" "$))' t/t-*.sh

Avoid modifying the test helpers, as there are places (such as calc_oid)
where we want to pass text containing escapes (such as "\n") and have
those be properly interpreted by printf(1).
2018-09-10 14:57:10 +00:00

68 lines
1.4 KiB
Bash
Executable File

#!/usr/bin/env bash
. "$(dirname "$0")/testlib.sh"
declare -a expiration_types=("absolute" "relative" "both")
for typ in "${expiration_types[@]}"; do
begin_test "expired action ($typ time)"
(
set -e
reponame="expired-$typ"
setup_remote_repo "$reponame"
clone_repo "$reponame" "$reponame"
contents="contents"
contents_oid="$(calc_oid "$contents")"
git lfs track "*.dat"
git add .gitattributes
git commit -m "initial commit"
printf "%s" "$contents" > a.dat
git add a.dat
git commit -m "add a.dat"
GIT_TRACE=1 git push origin master 2>&1 | tee push.log
if [ "0" -eq "${PIPESTATUS[0]}" ]; then
echo >&2 "fatal: expected push to fail, didn't"
exit 1
fi
refute_server_object "$reponame" "$contents_oid"
)
end_test
done
for typ in "${expiration_types[@]}"; do
begin_test "ssh expired ($typ time)"
(
set -e
reponame="ssh-expired-$typ"
setup_remote_repo "$reponame"
clone_repo "$reponame" "$reponame"
sshurl="${GITSERVER/http:\/\//ssh://git@}/$reponame"
git config lfs.url "$sshurl"
contents="contents"
contents_oid="$(calc_oid "$contents")"
git lfs track "*.dat"
git add .gitattributes
git commit -m "initial commit"
printf "%s" "$contents" > a.dat
git add a.dat
git commit -m "add a.dat"
GIT_TRACE=1 git push origin master 2>&1 | tee push.log
grep "ssh cache expired" push.log
)
end_test
done