Add support for metrics and pprof #100

2021-01-10T21:19:14Z

JosefWN commented

2021-01-10 21:19:14 +00:00

(Migrated from gitea.com)

Adds support for toggling support for pprof and metrics:

gitea:
  pprofEnabled: true

  metrics:
    enabled: true
    serviceMonitor:
      enabled: true

Adds support for toggling support for `pprof` and metrics: ```yaml gitea: pprofEnabled: true metrics: enabled: true serviceMonitor: enabled: true ```

techknowlogick (Migrated from gitea.com) reviewed 2021-01-10 22:13:47 +00:00

techknowlogick (Migrated from gitea.com) left a comment

please remove the .ds_store file that was added

JosefWN commented

2021-01-10 22:32:44 +00:00

(Migrated from gitea.com)

please remove the .ds_store file that was added

Dang, that's what I get for using git add -A... Removed: 2dfac46d45

> please remove the .ds_store file that was added Dang, that's what I get for using `git add -A`... Removed: https://gitea.com/gitea/helm-chart/commit/2dfac46d450512982a2662a40916fae960bd07db

techknowlogick (Migrated from gitea.com) reviewed 2021-01-10 22:33:34 +00:00

luhahn (Migrated from gitea.com) reviewed 2021-01-11 08:12:03 +00:00

luhahn (Migrated from gitea.com) reviewed 2021-01-11 13:10:34 +00:00

luhahn (Migrated from gitea.com) approved these changes 2021-01-11 16:00:22 +00:00

luhahn (Migrated from gitea.com) left a comment

looks good to me :)

JosefWN commented

2021-01-14 15:54:07 +00:00

(Migrated from gitea.com)

@techknowlogick I just rebased on master, do you have time to take another look for a second approval? :)

JosefWN commented

2021-01-21 07:58:50 +00:00

(Migrated from gitea.com)

@luhahn I rebased again now, can you please help me find someone to give a second approval before my fork is deleted in a week?

Hi,\n\nWe are sorry we have no enough diskspace to store all the mirror repositories. We will remove all of them, please back up all your mirror repositories on https://gitea.com. We will do that about 1 week later

@luhahn I rebased again now, can you please help me find someone to give a second approval before my fork is deleted in a week? > Hi,\n\nWe are sorry we have no enough diskspace to store all the mirror repositories. We will remove all of them, please back up all your mirror repositories on https://gitea.com. We will do that about 1 week later

luhahn commented

2021-01-21 13:11:36 +00:00

(Migrated from gitea.com)

Sure. Will try later that day when techknowlogick is available

techknowlogick commented

2021-01-21 15:45:16 +00:00

(Migrated from gitea.com)

@JosefWN not to worry. Your fork won't be deleted, only mirrors will be.

This LGTM, and so I can merge it now.

@JosefWN not to worry. Your fork won't be deleted, only mirrors will be. This LGTM, and so I can merge it now.

techknowlogick (Migrated from gitea.com) approved these changes 2021-01-21 15:45:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#100