lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Allow override kubernetes probes #117

Merged
viceice merged 1 commits from refs/pull/117/head into master 2021-03-01 14:46:06 +00:00
Conversation 7 Commits 1 Files Changed 1 +3 -3
viceice commented 2021-02-22 10:17:10 +00:00 (Migrated from gitea.com)
Copy Link
  • Allow overriding liveness and readiness probe
  • Add optional startup probe

closes #118

- Allow overriding liveness and readiness probe - Add optional startup probe closes #118
viceice commented 2021-02-22 10:24:30 +00:00 (Migrated from gitea.com)
Copy Link

Tested with helm template . to verify valid yaml. Should generate the probes as before this pr by default.

Tested with `helm template .` to verify valid yaml. Should generate the probes as before this pr by default.
luhahn commented 2021-02-23 15:53:17 +00:00 (Migrated from gitea.com)
Copy Link

thanks for the PR will test this tomorrow!

thanks for the PR will test this tomorrow!
luhahn (Migrated from gitea.com) approved these changes 2021-02-24 08:23:23 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Tested on my cluster with different values. Looks good to me!

Thanks for your effort :)

Tested on my cluster with different values. Looks good to me! Thanks for your effort :)
viceice commented 2021-02-24 08:28:39 +00:00 (Migrated from gitea.com)
Copy Link

No problem, like to see it merged soon 😉

No problem, like to see it merged soon :wink:
lafriks commented 2021-03-01 12:18:50 +00:00 (Migrated from gitea.com)
Copy Link

please resolve conflicts

please resolve conflicts
viceice commented 2021-03-01 12:33:16 +00:00 (Migrated from gitea.com)
Copy Link

done ?

done ?
lafriks (Migrated from gitea.com) approved these changes 2021-03-01 14:45:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lafriks
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#117
No description provided.
Delete Branch "refs/pull/117/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?