lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add app and version labels #121

Merged
Starefossen merged 3 commits from refs/pull/121/head into master 2021-03-01 12:20:56 +00:00
Conversation 4 Commits 3 Files Changed 2 +3 -1
Starefossen commented 2021-02-23 13:31:28 +00:00 (Migrated from gitea.com)
Copy Link

This pull request adds the app and version labels that are used by Istio.

Pods with app and version labels: We recommend adding an explicit app label and version label to the specification of the pods deployed using a Kubernetes Deployment. The app and version labels add contextual information to the metrics and telemetry that Istio collects.

  • The app label: Each deployment should have a distinct app label with a meaningful value. The app label is used to add contextual information in distributed tracing.

  • The version label: This label indicates the version of the application corresponding to the particular deployment.

From https://istio.io/latest/docs/ops/deployment/requirements/#pod-requirements

This pull request adds the `app` and `version` labels that are used by Istio. > Pods with app and version labels: We recommend adding an explicit app label and version label to the specification of the pods deployed using a Kubernetes Deployment. The app and version labels add contextual information to the metrics and telemetry that Istio collects. > > * The app label: Each deployment should have a distinct app label with a meaningful value. The app label is used to add contextual information in distributed tracing. > > * The version label: This label indicates the version of the application corresponding to the particular deployment. From https://istio.io/latest/docs/ops/deployment/requirements/#pod-requirements
luhahn commented 2021-02-23 15:56:00 +00:00 (Migrated from gitea.com)
Copy Link

Thanks for the PR! I will test your changes tomorrow :)

Thanks for the PR! I will test your changes tomorrow :)
luhahn (Migrated from gitea.com) reviewed 2021-02-24 08:09:30 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Not sure if this really is what we want

Not sure if this really is what we want
luhahn (Migrated from gitea.com) approved these changes 2021-02-24 14:15:38 +00:00
lafriks (Migrated from gitea.com) approved these changes 2021-03-01 12:20:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lafriks
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#121
No description provided.
Delete Branch "refs/pull/121/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?