Publish Chart on tag #13

2020-08-29T02:41:03Z

techknowlogick commented

2020-08-29 02:41:03 +00:00

(Migrated from gitea.com)

Note: Chart.yaml needs to have chart version modified (it won't use tag value at all)

Fixes #1

Note: Chart.yaml needs to have chart version modified (it won't use tag value at all) Fixes #1

lunny (Migrated from gitea.com) reviewed 2020-08-30 06:40:15 +00:00

luhahn commented

2020-08-31 15:48:47 +00:00

(Migrated from gitea.com)

Do I understand correctly, that the newest Release is only pushed, if we set a new tag to the master branch?

But since the tag is not used in the actual release name and helm does not have checks for this, could it be possible that an old release might be overwritten or does s3 complain about something like that?

Do I understand correctly, that the newest Release is only pushed, if we set a new tag to the master branch? But since the tag is not used in the actual release name and helm does not have checks for this, could it be possible that an old release might be overwritten or does s3 complain about something like that?

techknowlogick commented

2020-08-31 16:39:00 +00:00

(Migrated from gitea.com)

Do I understand correctly, that the newest Release is only pushed, if we set a new tag to the master branch?

The tag could also be on a different branch, but as drone doesn't know how to run specific events when the Chart value changes (well a drone extension could be written, but that is out of scope) so I use tag as that event (we should be git tagging version anyway)

But since the tag is not used in the actual release name and helm does not have checks for this, could it be possible that an old release might be overwritten or does s3 complain about something like that?

Yes, an old release may be overwritten, so we need to ensure those that tag releases also align the tags with Chart.yaml value.

> Do I understand correctly, that the newest Release is only pushed, if we set a new tag to the master branch? The tag could also be on a different branch, but as drone doesn't know how to run specific events when the Chart value changes (well a drone extension could be written, but that is out of scope) so I use tag as that event (we should be git tagging version anyway) > But since the tag is not used in the actual release name and helm does not have checks for this, could it be possible that an old release might be overwritten or does s3 complain about something like that? Yes, an old release may be overwritten, so we need to ensure those that tag releases also align the tags with Chart.yaml value.

lunny (Migrated from gitea.com) approved these changes 2020-09-02 12:23:48 +00:00

lunny (Migrated from gitea.com) left a comment

I think we can merge this at first and improve the CI process step by step.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#13