lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Let service.ssh.externalIPs and service.ssh.externalTrafficPolicy be configurable #15

Merged
onedr0p merged 1 commits from refs/pull/15/head into master 2020-09-02 12:09:29 +00:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
onedr0p commented 2020-08-30 19:17:59 +00:00 (Migrated from gitea.com)
Copy Link

Add two new config options:

|service.ssh.externalTrafficPolicy| If `service.ssh.type` is `NodePort` or `LoadBalancer`, set this to `Local` to enable source IP preservation | Cluster |
|service.ssh.externalIPs| SSH service external IP addresses |[]|

Having these be configurable would be great. Let me know if you need any further changes.

Add two new config options: ``` |service.ssh.externalTrafficPolicy| If `service.ssh.type` is `NodePort` or `LoadBalancer`, set this to `Local` to enable source IP preservation | Cluster | |service.ssh.externalIPs| SSH service external IP addresses |[]| ``` Having these be configurable would be great. Let me know if you need any further changes.
luhahn commented 2020-08-31 07:09:50 +00:00 (Migrated from gitea.com)
Copy Link

Thank you for the PR, I will check this today on my test cluster.

Thank you for the PR, I will check this today on my test cluster.
luhahn (Migrated from gitea.com) reviewed 2020-09-01 08:49:18 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Just a little something I'd like to change. Otherwise I've tested this PR on my Cluster and it looks fine to me :)

Just a little something I'd like to change. Otherwise I've tested this PR on my Cluster and it looks fine to me :)
luhahn (Migrated from gitea.com) reviewed 2020-09-01 11:39:32 +00:00
onedr0p commented 2020-09-01 11:39:53 +00:00 (Migrated from gitea.com)
Copy Link

@luhahn updated!

@luhahn updated!
luhahn (Migrated from gitea.com) approved these changes 2020-09-01 11:41:01 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Looks good to me

Looks good to me
lunny (Migrated from gitea.com) approved these changes 2020-09-02 12:09:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
lunny
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#15
No description provided.
Delete Branch "refs/pull/15/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?