lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fixing prometheus monitoring #157

Merged
modzilla merged 3 commits from master into master 2021-06-07 14:28:29 +00:00
Conversation 8 Commits 3 Files Changed 2 +4 -3
modzilla commented 2021-05-12 06:26:30 +00:00 (Migrated from gitea.com)
Copy Link

At least the latest versions of prometheus watch for a label called "release" and not "prometheus" so with that change prometheus started collecting logs.

If that old label is still needed, we / I could change it to add entries from "additionalLabels", so that we are quite flexible and don't have breaking changes.

At least the latest versions of prometheus watch for a label called "release" and not "prometheus" so with that change prometheus started collecting logs. If that old label is still needed, we / I could change it to add entries from "additionalLabels", so that we are quite flexible and don't have breaking changes.
luhahn commented 2021-05-25 06:40:46 +00:00 (Migrated from gitea.com)
Copy Link

let's go for additional labels for those using older prometheus versions.

Sorry for the late reply, was in vacation.

let's go for additional labels for those using older prometheus versions. Sorry for the late reply, was in vacation.
👍 1
modzilla commented 2021-06-01 10:24:59 +00:00 (Migrated from gitea.com)
Copy Link

Sure, you can now add labels to the ServiceMonitor instead :)

Sure, you can now add labels to the ServiceMonitor instead :)
👍 1
luhahn (Migrated from gitea.com) approved these changes 2021-06-07 07:40:01 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Looks good to me :)

Looks good to me :)
luhahn (Migrated from gitea.com) reviewed 2021-06-07 08:19:15 +00:00
modzilla commented 2021-06-07 08:21:08 +00:00 (Migrated from gitea.com)
Copy Link

Sorry, I opened the thread on my phone and accidentally missclicked :(

Sorry, I opened the thread on my phone and accidentally missclicked :(
luhahn (Migrated from gitea.com) approved these changes 2021-06-07 08:39:13 +00:00
luhahn commented 2021-06-07 09:32:13 +00:00 (Migrated from gitea.com)
Copy Link

Sorry once again, please update your branch with the latest master, after that we can merge it next

Sorry once again, please update your branch with the latest master, after that we can merge it next
techknowlogick (Migrated from gitea.com) approved these changes 2021-06-07 14:28:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#157
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?