Sensitive Mailer config settings via Kubernetes secrets #174

Closed
opened 2021-06-11 11:37:01 +00:00 by lord-kyron · 9 comments
lord-kyron commented 2021-06-11 11:37:01 +00:00 (Migrated from gitea.com)

Hi again,
for the same security purposes I requested the admin username and password to be able to put in k8s secrets, now I remembered, that the SMTP (Mailer) username and password are also sensitive info and can also be put under k8s secrets.

Can you again,please, implement this change if possible?

Thank you!

Hi again, for the same security purposes I requested the admin username and password to be able to put in k8s secrets, now I remembered, that the SMTP (Mailer) username and password are also sensitive info and can also be put under k8s secrets. Can you again,please, implement this change if possible? Thank you!
volker.raschek commented 2021-06-12 15:21:13 +00:00 (Migrated from gitea.com)

Not only the username and password of the mailer should be protected by a secret, the database credentials should also be secured by a secret!

Not only the username and password of the mailer should be protected by a secret, the database credentials should also be secured by a secret!
justusbunsi commented 2021-06-12 17:37:25 +00:00 (Migrated from gitea.com)
Same for oauth. ? EDIT: https://gitea.com/gitea/helm-chart/issues/242
lord-kyron commented 2021-06-15 07:11:38 +00:00 (Migrated from gitea.com)

@luhahn @lunny can youguys check this one,please ?

@luhahn @lunny can youguys check this one,please ?
luhahn commented 2021-06-19 16:26:11 +00:00 (Migrated from gitea.com)

I will try to implement this next week. It will be a bigger change because we will need to add env var parsing to the init container and infuse it into the app.ini

I will try to implement this next week. It will be a bigger change because we will need to add env var parsing to the init container and infuse it into the app.ini
tie commented 2021-10-30 11:33:14 +00:00 (Migrated from gitea.com)

Sorry to bother you guys (you're doing a fantastic job!!), but are there any news on this issue?

Sorry to bother you guys (you're doing a fantastic job!!), but are there any news on this issue?
lord-kyron commented 2021-10-30 12:44:13 +00:00 (Migrated from gitea.com)

Yes guys, I am still waiting for this feature to be available.

Yes guys, I am still waiting for this feature to be available.
justusbunsi commented 2021-10-30 13:08:41 +00:00 (Migrated from gitea.com)

@lord-kyron

Yes guys, I am still waiting for this feature to be available.

Afaik there is no progress on this issue.

We all do this in our spare time and it seems that there is not much of it in the past months. Any help (whether ideas on how to implement things or even providing PRs) is highly appreciated.

@lord-kyron >Yes guys, I am still waiting for this feature to be available. Afaik there is no progress on this issue. We all do this in our spare time and it seems that there is not much of it in the past months. Any help (whether ideas on how to implement things or even providing PRs) is highly appreciated.
justusbunsi commented 2021-11-13 11:28:47 +00:00 (Migrated from gitea.com)

? Gitea is smarter than me with referencing issues.

? Gitea is smarter than me with referencing issues.
justusbunsi commented 2021-11-19 23:20:53 +00:00 (Migrated from gitea.com)

? Don't know what I got wrong last time. Mailer config is inside app.ini. #240 will actually resolve this and even allow for more flexibility so that database credentials can be provided in a secure manner.

? Don't know what I got wrong [last time](https://gitea.com/gitea/helm-chart/pulls/240#issuecomment-690932). Mailer config _is_ inside `app.ini`. #240 will actually resolve this and even allow for more flexibility so that [database credentials](https://gitea.com/gitea/helm-chart/issues/174#issuecomment-440617) can be provided in a secure manner.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#174
No description provided.