lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix LDAP Ppassword env variable #182

Merged
luhahn merged 1 commits from refs/pull/182/head into master 2021-06-15 21:08:00 +00:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
luhahn commented 2021-06-15 20:26:52 +00:00 (Migrated from gitea.com)
Copy Link

Fixes: #179

Fixes: #179
zeripath (Migrated from gitea.com) approved these changes 2021-06-15 20:28:52 +00:00
techknowlogick (Migrated from gitea.com) approved these changes 2021-06-15 21:07:30 +00:00
justusbunsi commented 2021-06-15 21:08:02 +00:00 (Migrated from gitea.com)
Copy Link

TBH, this seems to not fully fix the regression or at least not fully finalize this feature. Previous to that PR, the admin user was created by using the LDAP bind settings (if I'm getting this right). Now with the correct environment variable for the LDAP credentials no admin user will be created when using existingSecret for the admin account. This feature was introduced with c49dc047a4 as well, I assume that we should fix this, too. Right now the admin account is only created when using inline credentials in values.yaml (see c49dc047a4/templates/gitea/init.yaml (L43))

TBH, this seems to not fully fix the regression or at least not fully finalize this feature. Previous to that PR, the admin user was created by using the LDAP bind settings (if I'm getting this right). Now with the correct environment variable for the LDAP credentials no admin user will be created when using `existingSecret` for the admin account. This feature was introduced with c49dc047a498973920e6743fa6c330fd2f81dd47 as well, I assume that we should fix this, too. Right now the admin account is only created when using inline credentials in `values.yaml` (see https://gitea.com/gitea/helm-chart/src/commit/c49dc047a498973920e6743fa6c330fd2f81dd47/templates/gitea/init.yaml#L43)
justusbunsi commented 2021-06-15 21:08:23 +00:00 (Migrated from gitea.com)
Copy Link

Oh no... too late.

Oh no... too late.
Sign in to join this conversation.
Reviewers
No Reviewers
zeripath
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone Release 4.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#182
No description provided.
Delete Branch "refs/pull/182/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?