lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Drop kebab-case configuration notation in favor of camelCase #188

New Issue
Closed
opened 2021-06-29 11:02:06 +00:00 by justusbunsi · 4 comments
justusbunsi commented 2021-06-29 11:02:06 +00:00 (Migrated from gitea.com)
Copy Link

As in title. It would remove complexity from the chart and reduces configuration failure rate.

As in title. It would remove complexity from the chart and reduces configuration failure rate.
viceice commented 2021-07-14 06:56:04 +00:00 (Migrated from gitea.com)
Copy Link

Wasn't the idea to switch from camelCase to kebab-case before? I though that wy the kebab-case options where previously istroduced.

ref #87

Wasn't the idea to switch from `camelCase` to `kebab-case` before? I though that wy the `kebab-case` options where previously istroduced. ref #87
luhahn commented 2021-07-14 07:24:23 +00:00 (Migrated from gitea.com)
Copy Link

@viceice

The general Idea was, that it should be possible to use the options as in https://docs.gitea.io/en-us/command-line/#admin
We never wanted to drop camelCase.
However that introduced some readability problems in the chart (lots of checks, if kebab-case or camelCase was used)
Since helm charts are generally using camelCase we decided to drop the kebab-case.

@viceice The general Idea was, that it should be possible to use the options as in https://docs.gitea.io/en-us/command-line/#admin We never wanted to drop camelCase. However that introduced some readability problems in the chart (lots of checks, if kebab-case or camelCase was used) Since helm charts are generally using camelCase we decided to drop the kebab-case.
viceice commented 2021-07-14 07:27:13 +00:00 (Migrated from gitea.com)
Copy Link

Ok, makes sense. I'll revert all my kebab-case changes. ?

Ok, makes sense. I'll revert all my `kebab-case` changes. ?
luhahn commented 2021-07-14 13:02:03 +00:00 (Migrated from gitea.com)
Copy Link

Sorry for the inconvenience!

Sorry for the inconvenience!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/breaking
Milestone
No items
No Milestone Release 4.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#188
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?