Drop custom{Liveness,Readiness,Startup}Probe options in favor of just re-configuring the default probes
#189
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It is not really necessary to provide different probe objects to override the default ones. One could just change the default configuration for the corresponding probe.
@justusbunsi is it possible to leave probes as it is now? I am using GCP and without using custom probes I am NOT able to route traffic to my load balancer. These Probes saved me tones of time. Removing them now would force me to go back to manual steps to configure my load balancer.
Hi @safaG. Thanks for your feedback. The idea is not to fully drop the customization of these probes. Right now there are two mostly identical options to configure them. The settings for
livenessProbe,readinessProbeandstartupProbeare not fully configurable. They are missing the actual action that will be done. That should be supported. Meaning: Take the whole content of these objects and use them as it is done with the currentcustomLivenessProbe,customReadinessProbeandcustomStartupProbe. Something similar is already possible for e.g.securityContext.Doing so should eliminate the need of two configuration options for the same thing each.
You know what I mean?
@justusbunsi ahh ok I see what you mean. Basically convert custom probes to the default probes and remove the custom probes.
Yep.