lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Document breaking changes #202

Merged
luhahn merged 1 commits from refs/pull/202/head into master 2021-07-12 17:33:38 +00:00
Conversation 1 Commits 1 Files Changed 1 +5
luhahn commented 2021-07-07 08:31:11 +00:00 (Migrated from gitea.com)
Copy Link

Documented some breaking changes. Please have a look and tell me, if I missed something :)

Fixes: #194

Documented some breaking changes. Please have a look and tell me, if I missed something :) Fixes: #194
justusbunsi (Migrated from gitea.com) reviewed 2021-07-07 16:39:46 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

What I am not sure about is, whether splitting the init script into two separate ones is a breaking change or not. I mean, in case someone used the initScript configuration to prepare some environmental stuff for the actual Gitea configuration (now the second init container), this wouldn't work anymore because that initScript is executated prior to that init container.

That would be the only thing missing here, if it's a breaking change.

What I am not sure about is, whether splitting the init script into two separate ones is a breaking change or not. I mean, in case someone used the initScript configuration to prepare some environmental stuff for the actual Gitea configuration (now the second init container), this wouldn't work anymore because that initScript is executated prior to that init container. That would be the only thing missing here, _if_ it's a breaking change.
justusbunsi (Migrated from gitea.com) reviewed 2021-07-09 07:09:30 +00:00
luhahn commented 2021-07-09 07:10:02 +00:00 (Migrated from gitea.com)
Copy Link

Updated PR with your suggestions, added description for dependency update (databases, memcached)

Updated PR with your suggestions, added description for dependency update (databases, memcached)
justusbunsi (Migrated from gitea.com) approved these changes 2021-07-12 07:48:38 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
lunny (Migrated from gitea.com) approved these changes 2021-07-12 15:56:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
lunny
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/docs
Milestone
No items
No Milestone Release 4.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#202
No description provided.
Delete Branch "refs/pull/202/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?