lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add support for ingressClassName #217

Merged
wkit23 merged 1 commits from master into master 2021-09-02 02:53:49 +00:00
Conversation 2 Commits 1 Files Changed 3
+6 -1
wkit23 commented 2021-08-31 06:52:36 +00:00 (Migrated from gitea.com)
Copy Link
Copy Source

Hi,

I just add some minor changes to support specifying ingressClassName to support the newer specification in networking.k8s.io/v1. The annotation kubernetes.io/ingress.class: nginx only works with older API networking.k8s.io/v1beta1.

This is part of our move to support kubernetes 1.22.

Hi, I just add some minor changes to support specifying ingressClassName to support the newer specification in `networking.k8s.io/v1`. The annotation `kubernetes.io/ingress.class: nginx` only works with older API `networking.k8s.io/v1beta1`. This is part of our move to support kubernetes 1.22.
luhahn (Migrated from gitea.com) approved these changes 2021-09-01 07:08:40 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link
Copy Source

Hi thank you for the PR, loogs good :)

Hi thank you for the PR, loogs good :)
techknowlogick (Migrated from gitea.com) approved these changes 2021-09-02 02:53:34 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
lunny (Lunny Xiao)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#217
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?