lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Add multiple LDAP sources #222

Merged
luhahn merged 1 commits from refs/pull/222/head into master 2021-10-08 12:16:24 +00:00
Conversation 3 Commits 1 Files Changed 2 +2 -2
luhahn commented 2021-09-20 09:40:13 +00:00 (Migrated from gitea.com)
Copy Link

Add multiple add sources.

Instead of a single entry for ldap configuration we now would have a dictionary for ldap config.

This would be a breaking change for those working with the ldap config.

fixes: #190

Add multiple add sources. Instead of a single entry for ldap configuration we now would have a dictionary for ldap config. This would be a breaking change for those working with the ldap config. fixes: #190
zeripath (Migrated from gitea.com) approved these changes 2021-09-23 14:36:04 +00:00
zeripath (Migrated from gitea.com) approved these changes 2021-09-23 14:36:05 +00:00
pat-s (Migrated from gitea.com) approved these changes 2021-09-25 07:36:24 +00:00
pat-s (Migrated from gitea.com) left a comment
Copy Link

Great! This should also path the way for multiple configs of other auth sources.

Great! This should also path the way for multiple configs of other auth sources.
justusbunsi (Migrated from gitea.com) reviewed 2021-09-27 19:04:44 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

Whitespaces breaks the template

Whitespaces breaks the template
pat-s commented 2021-09-27 20:03:46 +00:00 (Migrated from gitea.com)
Copy Link

Using the name as key for all references will fail as soon as there are whitespaces in it.

AFAIK YAML supports whitespaces when the keys are quoted? Would this help here? If this works, we could add an example of such a non-standard LDAP naming and explain shortly why its quoted.

> Using the name as key for all references will fail as soon as there are whitespaces in it. AFAIK YAML supports whitespaces when the keys are quoted? Would this help here? If this works, we could add an example of such a non-standard LDAP naming and explain shortly why its quoted.
justusbunsi commented 2021-09-27 20:20:02 +00:00 (Migrated from gitea.com)
Copy Link

Unfortunately not. I've tested it with quoted keys.

Unfortunately not. I've tested it with quoted keys.
👍 1
luhahn commented 2021-09-28 08:22:45 +00:00 (Migrated from gitea.com)
Copy Link

Now using a list instead of a dictionary. Also tested with whitespace names now :)

Now using a list instead of a dictionary. Also tested with whitespace names now :)
justusbunsi (Migrated from gitea.com) approved these changes 2021-10-08 12:15:28 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM. This is awesome.

LGTM. This is awesome.
Sign in to join this conversation.
Reviewers
No Reviewers
zeripath
pat-s
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/breaking
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#222
No description provided.
Delete Branch "refs/pull/222/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?