lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Ability to add pod annotation to statefulset #24

Merged
mmuenster merged 2 commits from master into master 2020-09-24 16:32:13 +00:00
Conversation 3 Commits 2 Files Changed 3 +14
mmuenster commented 2020-09-21 15:50:04 +00:00 (Migrated from gitea.com)
Copy Link

This pull request will allow users to add pod annotations to Gitea. To do so, users should add their annotations to 'podAnnotations' in values.yaml. The readme was updated with this information.

This pull request will allow users to add pod annotations to Gitea. To do so, users should add their annotations to 'podAnnotations' in values.yaml. The readme was updated with this information.
👍 1
luhahn commented 2020-09-21 15:55:46 +00:00 (Migrated from gitea.com)
Copy Link

Thanks for the PR, will test this tomorrow

Thanks for the PR, will test this tomorrow
luhahn (Migrated from gitea.com) approved these changes 2020-09-24 10:27:26 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

Tested on our clusters, works fine

Tested on our clusters, works fine
bclermont commented 2020-09-24 14:11:34 +00:00 (Migrated from gitea.com)
Copy Link

I was about to do the same PR, I really need this to implement https://velero.io/ backups

@mmuenster the PR is outdated, you should bump version

I was about to do the same PR, I really need this to implement https://velero.io/ backups @mmuenster the PR is outdated, you should bump [version](https://gitea.com/gitea/helm-chart/src/branch/master/Chart.yaml#L5)
techknowlogick (Migrated from gitea.com) approved these changes 2020-09-24 16:29:57 +00:00
techknowlogick commented 2020-09-24 16:31:35 +00:00 (Migrated from gitea.com)
Copy Link

@bclermont its ok if version isnt updated, a maintainer with write access is able to bump version after merge.

@bclermont its ok if version isnt updated, a maintainer with write access is able to bump version after merge.
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#24
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?