Drop default values for sensitive and contradictory values #241

New Issue

2021-11-13T10:25:01Z

justusbunsi commented

2021-11-13 10:25:01 +00:00

(Migrated from gitea.com)

Some values like gitea.admin.{username,password} and gitea.admin.existingSecret are contradictory and therefore must not exist at the same time.

For some settings, there are default values, which makes it easier to start using the Chart. At the same time those values can introduce security concerns if left unchanged, since those values are publicly readable.

I suggest dropping default values for both, contradictory and sensitive values. The first adds more stability to the Chart itself and paves the way for Option 2.2 of validation schema. The second increases the security of installations since the users have to define their own sensitive values.

Since this is a breaking change for all users relying on these default values (hopefully zero users affected), we could add example snippets for common configurations.

Some values like `gitea.admin.{username,password}` and `gitea.admin.existingSecret` are contradictory and therefore must not exist at the same time. For some settings, there are default values, which makes it easier to start using the Chart. At the same time those values can introduce security concerns if left unchanged, since those values are publicly readable. I suggest dropping default values for both, contradictory and sensitive values. The first adds more stability to the Chart itself and paves the way for [Option 2.2 of validation schema](https://gitea.com/gitea/helm-chart/pulls/198#issuecomment-593054). The second increases the security of installations since the users have to define their own sensitive values. Since this is a breaking change for all users relying on these default values (hopefully zero users affected), we could add example snippets for common configurations.

👍 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#241