lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Installation failes on argocd #251

New Issue
Closed
opened 2021-11-21 12:31:56 +00:00 by iMartyn · 1 comment
iMartyn commented 2021-11-21 12:31:56 +00:00 (Migrated from gitea.com)
Copy Link

Because argocd depends upon helm template, and the helm folks tend to not consider helm template, the use of

{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}}

does not do the right thing, and then the rendered yaml doesn't create the correct version of the object and everything falls over.

Suggestion (somewhat based on what airflow are doing on https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/flower/flower-ingress.yaml ) :

+{{- if .Values.ingress.APIVersionOverride -}}
+apiVersion: .Values.ingress.APIVersionOverride
+{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}}
-{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}}
apiVersion: networking.k8s.io/v1
{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1/Ingress" -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

This would allow overriding for those of us using argocd and not affect those using helm install / helm upgrade.

Because argocd depends upon `helm template`, and the helm folks tend to not consider `helm template`, the use of ``` {{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} ``` does not do the right thing, and then the rendered yaml doesn't create the correct version of the object and everything falls over. Suggestion (somewhat based on what airflow are doing on https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/flower/flower-ingress.yaml ) : ```diff +{{- if .Values.ingress.APIVersionOverride -}} +apiVersion: .Values.ingress.APIVersionOverride +{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} -{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} apiVersion: networking.k8s.io/v1 {{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1/Ingress" -}} apiVersion: networking.k8s.io/v1beta1 {{- else -}} apiVersion: extensions/v1beta1 {{- end }} ``` This would allow overriding for those of us using argocd and not affect those using helm install / helm upgrade.
iMartyn commented 2021-11-21 12:32:52 +00:00 (Migrated from gitea.com)
Copy Link

Note: I would create the PR myself but due to missing data on gitea.com, my fork is a 500 and therefore I can't interact with it, nor fork again.
Thanks to lunny, PR is possible again.

~~Note: I would create the PR myself but due to missing data on gitea.com, my fork is a 500 and therefore I can't interact with it, nor fork again.~~ Thanks to lunny, PR is possible again.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#251
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?