lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Move all password related data to secrets #28

Merged
luhahn merged 4 commits from master into master 2020-09-25 13:37:56 +00:00
Conversation 4 Commits 4 Files Changed 4 +6 -4
luhahn commented 2020-09-24 12:30:39 +00:00 (Migrated from gitea.com)
Copy Link

As stated in Issue #17 we should not save password related data in configmaps, since it can easily be read with kubectl.
This also applies to the init container, which sets the admin and ldap passwords.

This PR moves all this data to kubernetes secrets.

I'd like to discuss if this is enough to solve #17

As stated in Issue #17 we should not save password related data in configmaps, since it can easily be read with kubectl. This also applies to the init container, which sets the admin and ldap passwords. This PR moves all this data to kubernetes secrets. I'd like to discuss if this is enough to solve #17
lunny commented 2020-09-25 02:25:35 +00:00 (Migrated from gitea.com)
Copy Link

Please resolve the conflict.

Please resolve the conflict.
techknowlogick (Migrated from gitea.com) approved these changes 2020-09-25 02:57:27 +00:00
luhahn commented 2020-09-25 07:45:00 +00:00 (Migrated from gitea.com)
Copy Link

Is version 1.5.0 okay? I think we got a lot of improvements, so we can go to 1.5.

Is version 1.5.0 okay? I think we got a lot of improvements, so we can go to 1.5.
👍 1
lunny (Migrated from gitea.com) approved these changes 2020-09-25 13:37:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
techknowlogick
lunny
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#28
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?