Consider environment variables during app.ini creation #298

2022-02-25T09:32:58Z

luhahn commented

2022-02-25 09:32:58 +00:00

(Migrated from gitea.com)

This PR improves the handling and injection into app.ini of user defined environment variables via env-to-ini script.

Fixes #297

This PR improves the handling and injection into _app.ini_ of user defined environment variables via env-to-ini script. Fixes #297

👍 3

justusbunsi (Migrated from gitea.com) reviewed 2022-02-27 13:55:28 +00:00

justusbunsi commented

2022-02-27 14:32:22 +00:00

(Migrated from gitea.com)

Would also be a replacement for #279.

👍 1

justusbunsi (Migrated from gitea.com) reviewed 2022-03-02 09:14:25 +00:00

pat-s commented

2022-03-05 16:12:17 +00:00

(Migrated from gitea.com)

@luhahn Just a minor thing: Currently your README changes have a forced line-breaking at 80 chars or similar.
This makes it hard to review single sentences and probably also does not go well with https://gitea.com/gitea/helm-chart/src/branch/master/.markdownlint.yaml.

I wonder if a simple markdownlint check should be added to drone to automate this?

EDIT: Apparently there's already a check in the drone yaml: 9530967163/.drone.yml (L26-L30)

@luhahn Just a minor thing: Currently your README changes have a forced line-breaking at 80 chars or similar. This makes it hard to review single sentences and probably also does not go well with https://gitea.com/gitea/helm-chart/src/branch/master/.markdownlint.yaml. I wonder if a simple markdownlint check should be added to drone to automate this? EDIT: Apparently there's already a check in the drone yaml: https://gitea.com/gitea/helm-chart/src/commit/95309671630d7d3bcba97f389da8bd6a8847c8f7/.drone.yml#L26-L30

justusbunsi commented

2022-03-06 12:50:28 +00:00

(Migrated from gitea.com)

@luhahn Just a minor thing: Currently your README changes have a forced line-breaking at 80 chars or similar.
This makes it hard to review single sentences and probably also does not go well with https://gitea.com/gitea/helm-chart/src/branch/master/.markdownlint.yaml.

I wonder if a simple markdownlint check should be added to drone to automate this?

EDIT: Apparently there's already a check in the drone yaml: 9530967163/.drone.yml (L26-L30)

@pat-s I agree this is not the most readable setting right now. Would be another PR to globally change the line length for Markdown Lint.

> @luhahn Just a minor thing: Currently your README changes have a forced line-breaking at 80 chars or similar. > This makes it hard to review single sentences and probably also does not go well with https://gitea.com/gitea/helm-chart/src/branch/master/.markdownlint.yaml. > > I wonder if a simple markdownlint check should be added to drone to automate this? > > EDIT: Apparently there's already a check in the drone yaml: https://gitea.com/gitea/helm-chart/src/commit/95309671630d7d3bcba97f389da8bd6a8847c8f7/.drone.yml#L26-L30 @pat-s I agree this is not the most readable setting right now. Would be another PR to globally change the line length for Markdown Lint.

justusbunsi (Migrated from gitea.com) reviewed 2022-03-06 13:47:29 +00:00

justusbunsi (Migrated from gitea.com) approved these changes 2022-03-08 15:30:00 +00:00

justusbunsi (Migrated from gitea.com) left a comment

LGTM. Awesome addition. ?

6543 (Migrated from gitea.com) approved these changes 2022-03-09 00:45:15 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#298