lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Allow configuration of ipFamilyPolicy and ipFamilies #313

Merged
svenihoney merged 1 commits from master into master 2022-04-25 11:56:26 +00:00
Conversation 2 Commits 1 Files Changed 3 +14 -6
svenihoney commented 2022-04-17 09:02:05 +00:00 (Migrated from gitea.com)
Copy Link

To enable access to e.g. the SSH port by IPv6, the selection of ipFamilyPolicy and ipFamilies service attributes is necessary. Enable the possibility to configure these by helm values.

To enable access to e.g. the SSH port by IPv6, the selection of ipFamilyPolicy and ipFamilies service attributes is necessary. Enable the possibility to configure these by helm values.
techknowlogick commented 2022-04-21 03:59:45 +00:00 (Migrated from gitea.com)
Copy Link

Thanks for the PR :)

From a purely diff perspective, these changes look fine, although I'm not familiar enough with the ipfamily service attributes enough to say either way.

If another maintainer is fine with these too, then I'm happy to give my approval as well.

Thanks for the PR :) From a purely diff perspective, these changes look fine, although I'm not familiar enough with the ipfamily service attributes enough to say either way. If another maintainer is fine with these too, then I'm happy to give my approval as well.
justusbunsi (Migrated from gitea.com) reviewed 2022-04-21 09:18:08 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

In addition to the comments below, please add both new value parameters to the service section of README.md. Since the default value depend on each environment, I'd suggest linking the official Kubernetes dual-stack concept documentation: https://kubernetes.io/docs/concepts/services-networking/dual-stack/

In addition to the comments below, please add both new value parameters to the service section of [README.md](https://gitea.com/gitea/helm-chart/src/branch/master/README.md#service). Since the default value depend on each environment, I'd suggest linking the official Kubernetes dual-stack concept documentation: https://kubernetes.io/docs/concepts/services-networking/dual-stack/
justusbunsi (Migrated from gitea.com) reviewed 2022-04-21 15:42:54 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2022-04-21 19:04:49 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
justusbunsi commented 2022-04-21 19:22:05 +00:00 (Migrated from gitea.com)
Copy Link

If another maintainer is fine with these too, then I'm happy to give my approval as well.

@techknowlogick Ready for your approval. ?

> If another maintainer is fine with these too, then I'm happy to give my approval as well. @techknowlogick Ready for your approval. ?
luhahn (Migrated from gitea.com) approved these changes 2022-04-25 11:55:36 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
luhahn
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#313
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?