lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

feat: configurable annotations for gitea StatefulSet #315

Merged
takirala merged 1 commits from tga/configurable-annotations into master 2022-04-21 15:55:54 +00:00
Conversation 4 Commits 1 Files Changed 1 +1
takirala commented 2022-04-20 21:08:04 +00:00 (Migrated from gitea.com)
Copy Link

Fixes #314

Right now, the gitea StatefulSet does not allow any annotations to be configured via the helmchart - see https://gitea.com/gitea/helm-chart/src/tag/v5.0.4/templates/gitea/statefulset.yaml#L4-L6

My use case:

I am trying to use Reloader (https://github.com/stakater/Reloader) so that I can configure my values.yaml such that i can set some annotations on the StatefulSet and thus Reloader can rollout a restart of gitea StatefulSet whenever a watched secret or configmap is updated.

Fixes #314 Right now, the gitea StatefulSet does not allow any annotations to be configured via the helmchart - see https://gitea.com/gitea/helm-chart/src/tag/v5.0.4/templates/gitea/statefulset.yaml#L4-L6 My use case: I am trying to use Reloader (https://github.com/stakater/Reloader) so that I can configure my values.yaml such that i can set some annotations on the StatefulSet and thus Reloader can rollout a restart of gitea StatefulSet whenever a watched secret or configmap is updated.
takirala commented 2022-04-21 03:20:16 +00:00 (Migrated from gitea.com)
Copy Link

Ping @techknowlogick @luhahn
PTAL and let me know if there is anything i can do to make progress on this.

Ping @techknowlogick @luhahn PTAL and let me know if there is anything i can do to make progress on this.
techknowlogick (Migrated from gitea.com) approved these changes 2022-04-21 03:52:13 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2022-04-21 10:46:26 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2022-04-21 15:10:53 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
techknowlogick
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#315
No description provided.
Delete Branch "tga/configurable-annotations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?