lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Consider imagePullPolicy for init containers #317

Merged
justusbunsi merged 2 commits from refs/pull/317/head into master 2022-04-21 22:13:19 +00:00
Conversation 3 Commits 2 Files Changed 1 +3
justusbunsi commented 2022-04-21 09:12:40 +00:00 (Migrated from gitea.com)
Copy Link

The default behaviour for container image pulls depend on different values
such as image tag usage and its value.
See https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting

It leads to an unintended behaviour for this Helm Chart. Kubernetes
will always pull the image for init containers when using the latest
Gitea image tag, even if Values.image.pullPolicy defines a different
value for the runtime container.

The default behaviour for container image pulls depend on different values such as image tag usage and its value. See https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting It leads to an unintended behaviour for this Helm Chart. Kubernetes will always pull the image for init containers when using the `latest` Gitea image tag, even if `Values.image.pullPolicy` defines a different value for the runtime container.
techknowlogick (Migrated from gitea.com) approved these changes 2022-04-21 15:51:41 +00:00
Gusted (Migrated from gitea.com) approved these changes 2022-04-21 20:05:27 +00:00
takirala (Migrated from gitea.com) approved these changes 2022-04-21 21:13:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
techknowlogick
Gusted
takirala
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#317
No description provided.
Delete Branch "refs/pull/317/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?