lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Use healthz endpoint available with 1.17 #325

New Issue
Open
opened 2022-06-07 10:33:36 +00:00 by justusbunsi · 1 comment
justusbunsi commented 2022-06-07 10:33:36 +00:00 (Migrated from gitea.com)
Copy Link

Once Gitea 1.17 is available, we should consider switching to the healthz endpoint for liveness and readiness probes.
Maybe using a shell script to wrap the API call for backwards compatibility is good.

See https://github.com/go-gitea/gitea/pull/18465

When applying, do not use the same endpoint for both liveness and readiness probes. This is considered dangerous. See #553 and especially https://gitea.com/gitea/helm-chart/issues/553#issuecomment-754943.

Once Gitea 1.17 is available, we should consider switching to the healthz endpoint for liveness and readiness probes. Maybe using a shell script to wrap the API call for backwards compatibility is good. See https://github.com/go-gitea/gitea/pull/18465 When applying, do not use the same endpoint for both liveness and readiness probes. This is considered dangerous. See #553 and especially https://gitea.com/gitea/helm-chart/issues/553#issuecomment-754943.
viceice commented 2022-08-24 13:56:00 +00:00 (Migrated from gitea.com)
Copy Link

This is now unblocked, as the chart is already on v1.17.1 ?

This is now unblocked, as the chart is already on v1.17.1 ?
👍 3
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#325
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?